LGTM2 On Thu, Apr 27, 2023 at 7:02 AM Philip Jägenstedt <foo...@chromium.org> wrote:
> Great, with https://github.com/w3c/mediacapture-record/issues/219 filed > and the discussion you linked to, I don't think this needs to block. > > LGTM1 to ship given a surface-level test in WPT as discussed. > > On Thu, Apr 27, 2023 at 1:40 PM Markus Handell <hande...@google.com> > wrote: > >> Yep this topic was discussed on >> https://github.com/w3c/mediacapture-record/pull/216#discussion_r1159521616 >> and earlier. In the end I backed out of my proposed semantics due to >> scepticism so the PR leaves it unspecified. >> >> During the interim that hbos@ speaks to where the PR was merged, it was >> decided that a separate spec issue be filed on that topic, >> https://github.com/w3c/mediacapture-record/issues/219. >> >> >> On Thu, Apr 27, 2023 at 12:38 PM Philip Jägenstedt <foo...@chromium.org> >> wrote: >> >>> On Thu, Apr 27, 2023 at 9:24 AM Markus Handell <hande...@google.com> >>> wrote: >>> >>>> >>>>> Thanks for filing >>>>> https://github.com/web-platform-tests/wpt/issues/39642, I've asked >>>>> there for more details on what it would take to test this. >>>>> >>>>> >>>> I added some more detail there. >>>> >>>> >>>>> The spec change added two dictionary members to >>>>> https://w3c.github.io/mediacapture-record/#mediarecorderoptions-section >>>>> which means that it would at least be possible to add a test for >>>>> videoKeyFrameIntervalDuration and videoKeyFrameIntervalCount being >>>>> present. Can you write such a test? >>>>> >>>>> >>>> Yes! >>>> >>> >>> Thanks! It won't test the behavior, but will at least let the tests show >>> if there's some support or not, and catch typos in IDL, which happens. >>> >>> >>>> Also, I think vendor signals here aren't needed given the reviews on >>>>> https://github.com/w3c/mediacapture-record/pull/216, but can you file >>>>> bugs for Gecko and WebKit? >>>> >>>> >>>> Bugs filed: >>>> https://bugs.webkit.org/show_bug.cgi?id=256031 >>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1830236 >>>> >>> >>> Thank you! >>> >>> Skimming >>> https://w3c.github.io/mediacapture-record/#mediarecorderoptions-section >>> I have just one more question about interop here. The spec says "If both >>> videoKeyFrameIntervalDuration and videoKeyFrameIntervalCount are not null, >>> the UA may ignore either." It seems to me an implementation will definitely >>> pick one of them to ignore and it will be deterministic. Is there any >>> reason to leave this up to the UA instead of writing in the spec which >>> takes precedent? >>> >>> Best regards, >>> Philip >>> >>>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYf5CAXSME%2B4nmBT%2B2upB-2-hGh3MMJUn8j1M5%3DV4EYLxQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYf5CAXSME%2B4nmBT%2B2upB-2-hGh3MMJUn8j1M5%3DV4EYLxQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9cp4%3D6KfVqJv31b_K_3ONVSjAbF9E9kvqB9Z0bPOLNPg%40mail.gmail.com.
