Additional LGTMs? On Monday, April 24, 2023 at 6:58:20 PM UTC+3 Noam Rosenthal wrote:
Following up on this. I conducted a finch trial, which (expectedly) has shown no statistically significant performance impact. Note that the flag which the finch is based on only tests pages that attempted to reuse a prefetch. I would like to proceed with removing the 5 minute rule. Would be happy to provide more information. Thanks Noam On Wednesday, January 18, 2023 at 4:54:10 PM UTC+2 Daniel Bratell wrote: LGTM3 /Daniel On 2023-01-14 05:11, Noam Rosenthal wrote: On Fri, Jan 13, 2023 at 7:19 PM Yoav Weiss <yoav...@chromium.org> wrote: LGTM2 to launch this as a Finch experiment. On Fri, Jan 13, 2023 at 5:55 PM Rick Byers <rby...@chromium.org> wrote: LGTM1 from an API owners perspective. It's arguable whether this is "web-exposed" at all, or just a browser performance heuristic you're tweaking. >From a performance perspective, your argument and UMA analysis is compelling to me. But I've learned the hard way not to trust predictions of performance impact and instead rely on experiments :-). Were you planning on launching this with finch and validating the CWV impact? I think launching this as a Finch experiment makes a lot of sense. This is extremely unlikely to break content, but can result in a performance regression, so slow rollout seems like the best way to go here Sounds good, will proceed with finching this. Thanks! -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/ chromium.org/d/msgid/blink-dev/CAJn%3DMYZn7wV35v8W8ZwQN9oGSgVXcNsG 030E8-WEftWRkTz4zw%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJn%3DMYZn7wV35v8W8ZwQN9oGSgVXcNsG030E8-WEftWRkTz4zw%40mail.gmail.com?utm_medium=email&utm_source=footer> . -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5cd0fb6e-defd-42c5-87b0-83b90d81c7a5n%40chromium.org.
