I'm having a hard time assessing the risk, despite the very low usage
(it has doubled since the original email was sent - but still very low)
and other browsers shipping it.
That said, LGTM2 % having a base::Feature we can use as a killswitch, in
case we discover something we didn't anticipate.
On 8/9/23 8:12 PM, 'TAMURA, Kent' via blink-dev wrote:
LGTM1. It seems to have very low risk.
On Fri, Aug 4, 2023 at 4:53 PM Hayato Ito <hay...@chromium.org> wrote:
Contact emails
hay...@chromium.org
Specification
https://url.spec.whatwg.org/
Summary
Make URL parser to not decode percent-encoded ASCII characters in
URL's path, such as "%41" ('A'). Before this change: > const url =
new URL("http://example.com/%41";); > url.href
"http://example.com/A"After this change: > const url = new
URL("http://example.com/%41";); > url.href "http://example.com/%41";
Blink component
Blink>Network
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ENetwork>
TAG review
None
TAG review status
Not applicable
Risks
Interoperability and Compatibility
/Gecko/: Shipped/Shipping
/WebKit/: Shipped/Shipping
There are risks. Please see the WIP CL's description for details
(https://crrev.com/c/4607744).
I'd like to collect feedback about possible risks widely through
this thread.
The usage (Canary): 0.000106% (URL.Path.UnescapeEscapedChar
<https://uma.googleplex.com/p/chrome/timeline_v2/?sid=1bb9e227dc4889fd2efbf5755d256c62>).
This usage is not specific to any particular use case and can be
considered a theoretical upper bound. The actual breakage is
likely much lower than this number.
Will this feature be supported on all six Blink platforms
(Windows, Mac, Linux, Chrome OS, Android, and Android
WebView)?
Yes
Is this feature fully tested by web-platform-tests
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?
Yes
Tracking bug
https://crbug.com/1252531
Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/6389236793606144
--
Hayato
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFpjS_2-4PAY47VbDdd%2BHS%2BchmNUc9dW3BsRtW33LDr1QOeLGw%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFpjS_2-4PAY47VbDdd%2BHS%2BchmNUc9dW3BsRtW33LDr1QOeLGw%40mail.gmail.com?utm_medium=email&utm_source=footer>.
--
TAMURA, Kent
Software Engineer, Google
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqHcCModrUAQ%3DGJx-oiLcEmBwi%2BjU0ONCpnNWh%3Dp_THRdg%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqHcCModrUAQ%3DGJx-oiLcEmBwi%2BjU0ONCpnNWh%3Dp_THRdg%40mail.gmail.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b674e07c-7804-41d5-b8f5-7ada6295651b%40chromium.org.
