LGTM3 On 8/23/23 12:22 PM, Chris Harrelson wrote:
LGMT2On Wed, Aug 23, 2023 at 9:01 AM Yoav Weiss <yoavwe...@chromium.org> wrote: LGTM1 On Wed, Aug 23, 2023 at 5:26 PM Anders Hartvoll Ruud <andr...@chromium.org> wrote: On Wed, Aug 23, 2023 at 3:23 PM Yoav Weiss <yoavwe...@chromium.org> wrote: On Wed, Aug 23, 2023 at 2:46 PM Anders Hartvoll Ruud <andr...@chromium.org> wrote: Contact emails * andr...@chromium.org * Specification * https://github.com/w3c/csswg-drafts/issues/8926 <https://github.com/w3c/csswg-drafts/issues/8926> * Summary * The view-timelineshorthand is now a shorthand for view-timeline-name, view-timeline-axis, and view-timeline-inset. Previously, view-timeline-insetwas not part of the shorthand. This can theoretically be a problem if CSS like this exists: div { view-timeline-inset: 10px; view-timeline: mytimeline; } Currently, view-timeline(appearing later) would not interfere with view-timeline-insetabove, whereas with this change the view-timelinedeclaration sets view-timeline-insetto its initial value. Use-counters: * view-timeline: ~0.015% <https://chromestatus.com/metrics/css/timeline/popularity/728> * view-timeline-inset: ~0.019% <https://chromestatus.com/metrics/css/timeline/popularity/730> * No sample sites at the time of writing. However, for this to be a problem, a site needs to use bothview-timelineand view-timeline-inset. A HTTP Archive search [1] which looks for sites using both shows only 12 hits: 1 https://store.marketwatch.com/ 2 https://www.inbank.it/ 3 https://store.thetimes.ie/ 4 https://www.heraldsun.com.au/ 5 https://www.gameort.com/ 6 https://globalstore.thetimes.co.uk/ 7 https://assinaturaglobo.globo.com/ 8 https://mobile.thestar.com/ 9 https://readerschoice.thestar.com/ 10 https://sourcingjournal.com/ 11 https://ontario-doctors.thestar.com/ 12 http://fashion.telegraph.co.uk/ However, I can’t find any sign that these sites use view-timeline-[inset]from checking manually. If problems do appear, it can be fixed easily by e.g. using view-timeline-name/view-timeline-axisinstead of view-timeline, or re-ordering the declarations such that view-timeline-insetcomes after. * Blink component * Blink>Animation <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EAnimation> * TAG review * None * TAG review status * Not applicable * Risks * * Interoperability and Compatibility * None Gecko: No signal WebKit: No signal * Are we the first to implement this spec change? Yes. Only Chrome has shipped view-timeline at all so far. I think this doesn't warrant a full-fledged standards position, but can we extract signals from the CSSWG minutes? It was resolved without much discussion. https://log.csswg.org/irc.w3.org/css/2023-07-21/#e1557343 Can't really extract affirmative signals from the notes, although for this it's probably enough to note the lack of objection from people with opportunity to object. Fantasai (WebKit) presented the issue. I see e.g. Emilio (Mozilla) was active on the call as well. * Web developers: No signals Other signals: * WebView application risks * Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications? None * Debuggability * None * Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? * Yes * Is this feature fully tested by web-platform-tests <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>? * Yes (added in CL <https://chromium-review.googlesource.com/c/chromium/src/+/4798148>). * Can you add a flag in case we're wrong about the compat risk here? Yeah, will do. * * Flag name on chrome://flags * None * Finch feature name * None * Non-finch justification * None * Requires code in //chrome? * False * Estimated milestones * Shipping on desktop 118 Shipping on Android 118 Shipping on WebView 118 * Anticipated spec changes * Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way). None * Link to entry on the Chrome Platform Status https://chromestatus.com/feature/5201576423063552 <https://chromestatus.com/feature/5201576423063552> This intent message was generated by Chrome Platform Status <https://chromestatus.com/>. [1] #standardSQL SELECT pages.url FROM `httparchive.pages.2023_08_01_desktop` AS pages WHERE (JSON_EXTRACT(pages.payload, "$._blinkFeatureFirstUsed.Features['728']") IS NOT NULL AND JSON_EXTRACT(pages.payload, "$._blinkFeatureFirstUsed.Features['730']") IS NOT NULL);-- You received this message because you are subscribedto the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKFBnUpkoy4OgADAMhhGXmMsK7fLRxQLOPDK%2Bz6OJpHa5904vQ%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKFBnUpkoy4OgADAMhhGXmMsK7fLRxQLOPDK%2Bz6OJpHa5904vQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.-- You received this message because you are subscribed to the GoogleGroups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfX5KUdkm1ED7zPoxaxp2X1RM%3D0pcnhQsS9VY-h0bHrmXQ%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfX5KUdkm1ED7zPoxaxp2X1RM%3D0pcnhQsS9VY-h0bHrmXQ%40mail.gmail.com?utm_medium=email&utm_source=footer>. --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-yF%2BuNRav2s%2BhJBms1s-CTQwYOEsa4f%3DZ0xvRt7Tuy%3DA%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-yF%2BuNRav2s%2BhJBms1s-CTQwYOEsa4f%3DZ0xvRt7Tuy%3DA%40mail.gmail.com?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/1fae8e22-90c6-4373-9277-d8731e2e2c4d%40chromium.org.
