LGTM3 On Thu, Oct 26, 2023 at 4:04 PM Johnny Stenback <[email protected]> wrote:
> +1 to what Chris said. And if you feel a gate doesn't apply, you can state > in a comment that you believe the result of the review should be n/a. And > we're in fact in the midst of landing a short-hand button that does that > for all approval gate chips. > > Cheers, > Johnny > > On Thu, Oct 26, 2023 at 8:21 AM Chris Harrelson <[email protected]> > wrote: > >> >> >> On Wed, Oct 25, 2023 at 5:05 PM Shu-yu Guo <[email protected]> wrote: >> >>> Those gates are not applicable for most TC39 stage 3 features, including >>> this one. Are you asking them to be marked as such or that we requested >>> reviews for it? >>> >> >> I think they are. TC39 stage 3 features can skip a TAG review and >> signals, but the other fields are still required. >> >> >>> >>> On Wed, Oct 25, 2023 at 4:00 PM Mike Taylor <[email protected]> >>> wrote: >>> >>>> Oops... sent too early. Can you also please request reviews for the >>>> rest of the review gates >>>> <https://github.com/GoogleChrome/chromium-dashboard/wiki/Overview-of-Review-Gates> >>>> in the chromestatus entry? >>>> On 10/25/23 6:57 PM, Mike Taylor wrote: >>>> >>>> LGTM1. It's encouraging that Firefox Nightly shipped this a few months >>>> back <https://bugzilla.mozilla.org/show_bug.cgi?id=1795816> with no >>>> reported regressions thus far. >>>> On 10/25/23 6:39 PM, Rezvan Mahdavi Hezaveh wrote: >>>> >>>> Contact emails [email protected], [email protected] >>>> >>>> Explainer https://github.com/tc39/proposal-array-from-async >>>> >>>> Specification https://tc39.es/proposal-array-from-async >>>> >>>> Summary >>>> >>>> Array.fromAsync is the async version of Array.from. It takes async >>>> iterables, iterates them, and collects the results into an array. >>>> >>>> >>>> Blink component Blink>JavaScript>Language >>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EJavaScript%3ELanguage> >>>> >>>> TAG review None >>>> >>>> TAG review status Not applicable >>>> >>>> Risks >>>> >>>> >>>> Interoperability and Compatibility >>>> >>>> No known interop or web compat risk. >>>> >>>> >>>> *Gecko*: Positive (https://bugzilla.mozilla.org/show_bug.cgi?id=1746209) >>>> This is a TC39 Stage 3 proposal. >>>> >>>> *WebKit*: Positive This is a TC39 Stage 3 proposal. >>>> >>>> *Web developers*: Positive ( >>>> https://twitter.com/erickwendel_/status/1555206623836127232) Seems >>>> positive, lots of likes on Twitter. >>>> >>>> *Other signals*: >>>> >>>> WebView application risks >>>> >>>> Does this intent deprecate or change behavior of existing APIs, such >>>> that it has potentially high risk for Android WebView-based applications? >>>> >>>> None >>>> >>>> >>>> Debuggability >>>> >>>> It is debugged as any other static method in JavaScript. >>>> >>>> >>>> Will this feature be supported on all six Blink platforms (Windows, >>>> Mac, Linux, Chrome OS, Android, and Android WebView)? Yes >>>> >>>> Is this feature fully tested by web-platform-tests >>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>> ? Yes >>>> >>>> https://github.com/tc39/test262/issues/3725 >>>> >>>> >>>> Flag name on chrome://flags --harmony_array_from_async >>>> >>>> Finch feature name None >>>> >>>> Non-finch justification None >>>> >>>> Requires code in //chrome? False >>>> >>>> Tracking bug https://bugs.chromium.org/p/v8/issues/detail?id=13321 >>>> >>>> Estimated milestones >>>> DevTrial on desktop 120 >>>> DevTrial on Android 120 >>>> >>>> Anticipated spec changes >>>> >>>> Open questions about a feature may be a source of future web compat or >>>> interop issues. Please list open issues (e.g. links to known github issues >>>> in the project for the feature specification) whose resolution may >>>> introduce web compat/interop risk (e.g., changing to naming or structure of >>>> the API in a non-backward-compatible way). >>>> None >>>> >>>> Link to entry on the Chrome Platform Status >>>> https://chromestatus.com/feature/5069575759069184 >>>> >>>> This intent message was generated by Chrome Platform Status >>>> <https://chromestatus.com/>. >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACJ3t%2Bg4MwKGhiGJg%2B0WdgJXTD0rGJ22ZFGAF8bnOtGoLhszzA%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACJ3t%2Bg4MwKGhiGJg%2B0WdgJXTD0rGJ22ZFGAF8bnOtGoLhszzA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/591771b3-56e8-4f56-aba2-f66241221d29%40chromium.org >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/591771b3-56e8-4f56-aba2-f66241221d29%40chromium.org?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN-e9e_2hjvbBo5Bhpy7PfzxvEMH90ZnK%2B5_i8YQ2PoKFaS_bw%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN-e9e_2hjvbBo5Bhpy7PfzxvEMH90ZnK%2B5_i8YQ2PoKFaS_bw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_Hks-fS9hv%3D0q83FqzxDpp3MS5DpGicQiBrZwmzOK_%3DA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_Hks-fS9hv%3D0q83FqzxDpp3MS5DpGicQiBrZwmzOK_%3DA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACZRgz5HA6%3DygCeHUxTymz%3Dh4%2BgYc4-PGm0YTSg1EKC5Y8gGaA%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACZRgz5HA6%3DygCeHUxTymz%3Dh4%2BgYc4-PGm0YTSg1EKC5Y8gGaA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_gVXXVTkP7oykChOC%3DJwoJy0gDB-KgVMwq5x%2BRRkBT%2BA%40mail.gmail.com.
