LGTM2
On 11/30/23 6:10 PM, Rick Byers wrote:
LGTM1
On Fri, Dec 1, 2023 at 4:55 AM 'Liam Brady' via blink-dev
<[email protected]> wrote:
Contact emails
[email protected] <mailto:[email protected]>,
[email protected] <mailto:[email protected]>,
[email protected] <mailto:[email protected]>,
[email protected] <mailto:[email protected]>
Explainer(s)
Enable Leaving Ad Interest Groups from Urn iFrames and Ad
Component Frames
https://github.com/WICG/turtledove/pull/879
<https://github.com/WICG/turtledove/pull/879>
https://github.com/WICG/turtledove/blob/11d500c87bb39540d49c8e369a87d6ca84ee5824/FLEDGE.md#11-joining-interest-groups
<https://github.com/WICG/turtledove/blob/11d500c87bb39540d49c8e369a87d6ca84ee5824/FLEDGE.md#11-joining-interest-groups>
Introduce reserved.top_navigation_start/commit
https://github.com/WICG/turtledove/pull/885
<https://github.com/WICG/turtledove/pull/885>
Spec(s)
Enable Leaving Ad Interest Groups from URN iframes and Ad
Component Frames
https://wicg.github.io/turtledove/#leaveadinterestgroup
<https://wicg.github.io/turtledove/#leaveadinterestgroup>
Introduce reserved.top_navigation_start/commit
https://github.com/WICG/fenced-frame/pull/130
<https://github.com/WICG/fenced-frame/pull/130>
Summary
We launched Fenced Frames as a part of Chrome 115. We would like
to make the following two changes to Fenced Frames to help improve
experimentation. Note that changes to Fenced Frames Ads Reporting
applies to both fenced frames and URN iframes.
1. Enable Leaving Ad Interest Groups from URN iframes and Ad
Component Frames
Currently calling navigator.leaveAdInterestGroup() without any
argument only works in fenced frames. This change enables this API
for supporting navigator.leaveAdInterestGroup() without any
argument in URN iframes and in ad component frames.
This change is being made to provide consistency of behavior
across the various frame types.
2. Introduce reserved.top_navigation_start/commit
Fenced frames or URN iframes, when loaded through an API like
Protected Audience or Shared Storage, can send out reporting
beacons automatically when a top-level navigation initiated by the
frame commits. With this change, we are additionally adding
automatic beacon support for top-level navigation start events
through the "reserved.top_navigation_start" event type. The
top-level navigation commit event is renamed from
"reserved.top_navigation" to "reserved.top_navigation_commit" to
have a more clear naming convention (for now, both the new and old
name will continue to work). This change also adds console
warnings on the usage of "reserved.top_navigation" to help with
its eventual deprecation, which will involve gathering metrics on
its usage and deprecating when those metrics reduce considerably.
This change allows adtech to receive more complete reporting as
discussed in the related issue
<https://github.com/WICG/turtledove/issues/822>.
Blink component
Blink>FencedFrames
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EFencedFrames>
TAG reviews and status
Fenced frames existing TAG review appended with these spec changes
https://github.com/w3ctag/design-reviews/issues/838#issuecomment-1792881253
<https://github.com/w3ctag/design-reviews/issues/838#issuecomment-1792881253>
Link to Origin Trial feedback summary
No Origin Trial performed
Is this feature supported on all six Blink platforms (Windows,
Mac, Linux, Chrome OS, Android, and Android WebView)?
Supported on all the above platforms except Android WebView.
Debuggability
Additional debugging capabilities are not necessary for these
feature changes.
Risks
Compatibility
There are no compatibility risks, as described below:
1. Enable Leaving Ad Interest Groups from Urn iFrames and Ad
Component Frames:
This is added functionality and backward compatible.
2. Introduce reserved.top_navigation_start/commit:
This is added functionality and backward compatible.
Interoperability
There are no interoperability risks as no other browsers have
decided to implement these features yet.
Is this feature fully tested by web-platform-tests
<https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?
Link to test suite results from wpt.fyi <https://wpt.fyi>.
1. Enable Leaving Ad Interest Groups from Urn iFrames and Ad
Component Frames:
Yes.
https://github.com/web-platform-tests/wpt/blob/master/fledge/tentative/join-leave-ad-interest-group.https.window.js
<https://github.com/web-platform-tests/wpt/blob/master/fledge/tentative/join-leave-ad-interest-group.https.window.js>
https://github.com/web-platform-tests/wpt/blob/master/fledge/tentative/join-leave-ad-interest-group-in-fenced-frame.https.window.js
<https://github.com/web-platform-tests/wpt/blob/master/fledge/tentative/join-leave-ad-interest-group-in-fenced-frame.https.window.js>
2. Introduce reserved.top_navigation_start/commit:
Yes. The existing automatic beacon tests have been updated
<https://github.com/web-platform-tests/wpt/commit/da07db4e03aacb060c82996f4ed7b8f0dd4e4b24>to
test the new automatic beacon types.
example of top_navigation_start and top_navigation_commit test:
automatic-beacon-click-handler.https.html (test
<https://github.com/web-platform-tests/wpt/blob/master/fenced-frame/automatic-beacon-click-handler.https.html>)
(results
<https://wpt.fyi/results/fenced-frame/automatic-beacon-click-handler.https.html?label=experimental&label=master&aligned>)
automatic-beacon-shared-storage.https.html (test
<https://github.com/web-platform-tests/wpt/blob/master/fenced-frame/automatic-beacon-shared-storage.https.html>)
(results
<https://wpt.fyi/results/fenced-frame/automatic-beacon-shared-storage.https.html?label=experimental&label=master&aligned>)
WPT for Fenced Frames:
https://github.com/web-platform-tests/wpt/tree/master/fenced-frame
<https://github.com/web-platform-tests/wpt/tree/master/fenced-frame>
Anticipated spec changes
None
Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5149287986233344
<https://chromestatus.com/feature/5149287986233344>
Links to previous Intent discussions
Intent to prototype:
https://groups.google.com/a/chromium.org/g/blink-dev/c/Ko9UXQYPgUE/m/URRsB-qvAAAJ
<https://groups.google.com/a/chromium.org/g/blink-dev/c/Ko9UXQYPgUE/m/URRsB-qvAAAJ>
Intent to experiment:
https://groups.google.com/a/chromium.org/g/blink-dev/c/y6G3cvKXjlg/m/Lcpmpi_LAgAJ
<https://groups.google.com/a/chromium.org/g/blink-dev/c/y6G3cvKXjlg/m/Lcpmpi_LAgAJ>
Intent to ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/tpw8wW0VenQ/m/mePLTiHlDQAJ
<https://groups.google.com/a/chromium.org/g/blink-dev/c/tpw8wW0VenQ/m/mePLTiHlDQAJ>
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected].
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/38a73d81-a439-46e8-9573-d5c66789fdc6n%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/38a73d81-a439-46e8-9573-d5c66789fdc6n%40chromium.org?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_wKQU%2B8TZ%2B-LsacF%2B4%3DcLkg2CVZ5Ff_V9J%2BU4aUDHy0g%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_wKQU%2B8TZ%2B-LsacF%2B4%3DcLkg2CVZ5Ff_V9J%2BU4aUDHy0g%40mail.gmail.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f4893a5e-798e-451f-af95-b91f4ab22757%40chromium.org.