LGTM1

This seems like a small and useful extension to Document picture-in-picture.

On Tue, Feb 13, 2024 at 11:13 AM 'François Beaufort' via blink-dev <
blink-dev@chromium.org> wrote:

> Contact emailsfbeauf...@google.com
>
> ExplainerNone
>
> Specification
> https://drafts.csswg.org/mediaqueries-5/#display-mode-picture-in-picture
> https://github.com/w3c/csswg-drafts/issues/9260
>
> Summary
>
> Adds support to the CSS display-mode media feature for picture-in-picture.
> This allows web developers to write specific CSS rules that are only
> applied when (part of the) the web app is shown in picture-in-picture mode.
>
>
> Blink componentBlink>CSS
> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ECSS>
>
> TAG reviewNone
>
> TAG review statusNot applicable as this is a minor change to the behavior
> of an existing API
>

Maybe comment with this on a the broader feature's TAG review, similar to
what you did for vendor positions?


>
>
> Risks
>
>
> Interoperability and Compatibility
>
> None
>
>
> *Gecko*: No signal (
> https://github.com/WebKit/standards-positions/issues/41#issuecomment-1940908587)
> Added comment to existing standards position issue for document
> picture-in-picture. No response yet
>
> *WebKit*: No signal (
> https://github.com/mozilla/standards-positions/issues/670#issuecomment-1940909277)
> Added comment to existing standards position issue for document
> picture-in-picture. No response yet
>
> *Web developers*: Positive (
> https://github.com/WICG/document-picture-in-picture/issues/87)
>
> *Other signals*:
>
> WebView application risks
>
> Does this intent deprecate or change behavior of existing APIs, such that
> it has potentially high risk for Android WebView-based applications?
>
> None
>
>
> Debuggability
>
> No DevTools changes are required, treated like any other CSS property.
>
>
> Will this feature be supported on all six Blink platforms (Windows, Mac,
> Linux, ChromeOS, Android, and Android WebView)?No
>
> The document picture-in-picture API is not supported on Android
>
>
> Is this feature fully tested by web-platform-tests
> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>
> ?Yes
>
> https://wpt.fyi/results/css/mediaqueries/display-mode.html
> https://wpt.live/css/mediaqueries/display-mode.html
>
>
> Flag name on chrome://flagsExperimental Web Platform Features
>
> Finch feature nameCSSDisplayModePictureInPicture
>
> Requires code in //chrome?True
>
> Tracking bughttps://issues.chromium.org/issues/41493667
>
> Sample links
> https://document-picture-in-picture-api.glitch.me/display-mode.html
>
> Estimated milestones
> Shipping on desktop 123
>
> Anticipated spec changes
>
> Open questions about a feature may be a source of future web compat or
> interop issues. Please list open issues (e.g. links to known github issues
> in the project for the feature specification) whose resolution may
> introduce web compat/interop risk (e.g., changing to naming or structure of
> the API in a non-backward-compatible way).
> None
>
> Link to entry on the Chrome Platform Status
> https://chromestatus.com/feature/5198101675769856
>
> Links to previous Intent discussionsIntent to prototype:
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPpwU5LESxPG9gA5-_uvsBiAZpqdvRkNfxL7Az%3DSNSUi4UNSkA%40mail.gmail.com
>
> This intent message was generated by Chrome Platform Status
> <https://chromestatus.com/>.
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPpwU5JsF6bdXuvH3XvqEE_PBy%2BkY3oYdKG_%2BzYHynGM1X7Uxw%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPpwU5JsF6bdXuvH3XvqEE_PBy%2BkY3oYdKG_%2BzYHynGM1X7Uxw%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSKeLFq5ALQMs3pHkaLXQ9At5frU0ZZode7uaF--M4Aq_A%40mail.gmail.com.

Reply via email to