LGTM3 On Thu, Mar 7, 2024 at 3:35 AM Yoav Weiss (@Shopify) <yoavwe...@chromium.org> wrote:
> LGTM2 > > On Wed, Mar 6, 2024 at 7:23 PM Mike Taylor <miketa...@chromium.org> wrote: > >> LGTM1 >> On 3/6/24 11:00 AM, Vladimir Levin wrote: >> >> Re failing tests: >> The flag is currently in "test" status >> <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/runtime_enabled_features.json5;l=1420;drc=3690cd7872423e81e74dc66f9886e355a7c1b659> >> which >> I don't believe would be picked up by wpt.fyi experimental run. >> >> Re explainer for non-vt cases: >> We added several other examples >> <https://github.com/WICG/view-transitions/blob/main/document-render-blocking.md#other-use-cases> >> to the explainer (thanks Noam!) >> >> Re console warning: >> Good catch indeed. We'll make sure to address >> https://issues.chromium.org/issues/328279707 in a timely manner. >> >> <webperfwg hat on> > I'd also strongly encourage y'all to also add some reporting on that front. > +Ian Clelland <iclell...@google.com> FYI > >> >> >> On Wed, Mar 6, 2024 at 10:18 AM Jake Archibald <jaffathec...@gmail.com> >> wrote: >> >>> The design of this looks great. Filed a couple of very minor spec nuts >>> https://github.com/whatwg/html/issues/10180 >> >> >> Thanks! 🔩 >> >> >>> >>> >>> On Monday 4 March 2024 at 16:36:43 UTC vmp...@chromium.org wrote: >>> >>>> Contact emails vmp...@chromium.org, nrose...@chromium.org >>>> >>>> Explainer >>>> https://github.com/WICG/view-transitions/blob/main/document-render-blocking.md#blocking-element-id >>>> >>>> Specification >>>> https://html.spec.whatwg.org/multipage/links.html#link-type-expect >>>> >>>> Summary >>>> >>>> This feature enables authors to block rendering of a Document until the >>>> critical content has been parsed, ensuring a consistent first paint across >>>> all browsers. Without this feature, the first paint's state depends on the >>>> heuristics for parser yielding which can vary across browsers. This is >>>> particularly important for View Transitions where the parsed DOM state on >>>> the first frame can drastically change the transition created. Note that >>>> this feature specifically implements a `<link rel=expect href="#id">` >>>> syntax that allows a link element to reference another expected element on >>>> the page. The rendering is then blocked until the expected element is fully >>>> parsed. This supersedes previous implementation of html attribute that >>>> allows the whole document to be render blocked. >>>> >>>> >>>> Blink component Blink>ViewTransitions>MPA >>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EViewTransitions%3EMPA> >>>> >>>> TAG review https://github.com/w3ctag/design-reviews/issues/886 >>>> >>>> TAG review status Issues addressed >>>> >>>> Risks >>>> >>>> >>>> Interoperability and Compatibility >>>> >>>> None >>>> >>>> >>>> *Gecko*: Positive ( >>>> https://github.com/mozilla/standards-positions/issues/875) >>>> >>>> *WebKit*: No signal ( >>>> https://github.com/WebKit/standards-positions/issues/245) >>>> >>>> *Web developers*: Positive (https://github.com/whatwg/html/issues/9332) >>>> There are some discussions between implementors and developers on this >>>> issue. This feature is also a requisite feature for cross-document View >>>> Transition adoption, which has strong positive signals ( >>>> https://daverupert.com/2023/05/getting-started-view-transitions/). >>>> >>>> *Other signals*: >>>> >>>> Ergonomics >>>> >>>> This feature would be used frequently with cross-document View >>>> Transitions, because it allows the browser to wait for necessary content to >>>> be parsed. >>>> >>>> >>>> Activation >>>> >>>> This feature can be used directly. >>>> >>>> >>>> WebView application risks >>>> >>>> Does this intent deprecate or change behavior of existing APIs, such >>>> that it has potentially high risk for Android WebView-based applications? >>>> >>>> There are no WebView application risks >>>> >>>> >>>> Debuggability >>>> >>>> None >>>> >>>> >>>> Will this feature be supported on all six Blink platforms (Windows, >>>> Mac, Linux, ChromeOS, Android, and Android WebView)? Yes >>>> >>>> Is this feature fully tested by web-platform-tests >>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>> ? Yes >>>> >>>> >>>> https://wpt.fyi/results/html/dom/render-blocking?label=master&label=experimental&aligned&q=element-render-blocking >>>> Note that we will be renaming these from .tentative shortly >>>> >>>> >>>> Flag name on chrome://flags None >>>> >>>> Finch feature name DocumentRenderBlocking >>>> >>>> Requires code in //chrome? False >>>> >>>> Adoption expectation This feature is expected to be adopted by >>>> developers using cross-document View Transitions >>>> >>>> Estimated milestones >>>> Shipping on desktop 124 >>>> Shipping on Android 124 >>>> Shipping on WebView 124 >>>> >>>> Anticipated spec changes >>>> >>>> Open questions about a feature may be a source of future web compat or >>>> interop issues. Please list open issues (e.g. links to known github issues >>>> in the project for the feature specification) whose resolution may >>>> introduce web compat/interop risk (e.g., changing to naming or structure of >>>> the API in a non-backward-compatible way). >>>> None >>>> >>>> Link to entry on the Chrome Platform Status >>>> https://chromestatus.com/feature/5113053598711808 >>>> >>>> Links to previous Intent discussions Intent to prototype: >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMLuWUzNfD4MRk0bR1yTZ5F6NzcpETrUU3Vy9GmANZRQd7%3DE4A%40mail.gmail.com >>>> >>>> This intent message was generated by Chrome Platform Status >>>> <https://chromestatus.com/>. >>>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2N7%3D1bHWub6UwxgfvSVdrukfhNTDbWaniW88a4rxxd%2BJw%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2N7%3D1bHWub6UwxgfvSVdrukfhNTDbWaniW88a4rxxd%2BJw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/03e4d6cc-b1f5-43f2-825c-f6c8eb28f006%40chromium.org >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/03e4d6cc-b1f5-43f2-825c-f6c8eb28f006%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSLfsS7ZDG3Pe%2B4DDCqT%3DZaRicOvzD5Pwmm544tcFwWP9A%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSLfsS7ZDG3Pe%2B4DDCqT%3DZaRicOvzD5Pwmm544tcFwWP9A%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra_xXQ4c766jQjYZgNMjpTubNH8SoZZ%2B0AD6XQJjEeHGug%40mail.gmail.com.
