LGTM3 /Daniel
On 2024-03-27 16:16, Yoav Weiss (@Shopify) wrote:
LGTM2 On Tuesday, March 26, 2024 at 7:25:13 PM UTC+1 Akash Nadan wrote: Hi Yoav, the reasoning behind this change is that there is a privacy gap with the current attribution flow and position of the source deactivation logic. The current position of the source deactivation logic makes it possible for API callers to identify when a source is noise (versus a real source) in certain scenarios. Additional details/example in this Github issue: https://github.com/WICG/attribution-reporting-api/issues/842 <https://github.com/WICG/attribution-reporting-api/issues/842> Regarding the implications, an ad-tech may get different reports in some circumstances (or no report where they previously would have gotten one) which may have implications when they are comparing these reports to other mechanisms they may be using for conversion measurement. They may see a slight difference in those comparisons, although given that this scenario is rare, it may not cause any issues or change in comparison. Let me know if you have any other questions.Thanks for the explanation. I'd consider this a (barely) web-exposed bug fix.Thanks, Akash On Tuesday, March 26, 2024 at 10:54:02 AM UTC-7 Yoav Weiss (@Shopify) wrote: On Tuesday, March 19, 2024 at 12:18:00 AM UTC+1 Akash Nadan wrote: Contact emails akash...@google.com, lin...@chromium.org, john...@chromium.org Explainer Attribution Reporting with event-level reports <https://github.com/WICG/attribution-reporting-api/blob/main/EVENT.md> Attribution Reporting API with Aggregatable Reports <https://github.com/WICG/attribution-reporting-api/blob/main/AGGREGATE.md> Aggregation Service for the Attribution Reporting API <https://github.com/WICG/attribution-reporting-api/blob/main/AGGREGATION_SERVICE_TEE.md> Specification https://wicg.github.io/attribution-reporting-api/ <https://wicg.github.io/attribution-reporting-api/> Blink component Internals > AttributionReporting <https://bugs.chromium.org/p/chromium/issues/list?q=component:Internals%3EAttributionReporting> Summary We are landing the following changes to the Attribution Reporting API focused on: * additional debugging capabilities by supporting parsing failure debug reports * improving API ergonomics by supporting a field to specify preferred registration platform * improving privacy Explainer/Spec changes 1. Response header errors debug reports <https://github.com/WICG/attribution-reporting-api/pull/1180> 2. Supporting preferred platform for cross app attribution <https://github.com/WICG/attribution-reporting-api/pull/1161> 3. Move source deactivation step after top level filter matching <https://github.com/WICG/attribution-reporting-api/pull/851> Can you provide more details on the reasoning and implications of (3)? A lack of explainer or details on the PR itself make it somewhat of an opaque change.. Risks Interoperability and Compatibility (1 <https://github.com/WICG/attribution-reporting-api/pull/1180>) Header errors debug reports and (2 <https://github.com/WICG/attribution-reporting-api/pull/1161>) preferred platform are both fully backwards compatible changes and are optional features. (3 <https://github.com/WICG/attribution-reporting-api/pull/851>) The source deactivation change has very low compatibility risk because it does not require any developer changes and only results in ad techs getting different reports in cases where a user had multiple interactions across different ads when rate limits in the API are hit, which should be very rare. Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? The attribution reporting feature bundle will be supported on all platforms with the exception of Android WebView Is this feature fully tested by web-platform-tests <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>? Yes Estimated milestones This feature bundle is anticipated to ship as part ofChrome 124 <https://chromiumdash.appspot.com/schedule>. Link to entry on the Chrome Platform Status https://chromestatus.com/feature/5117902786396160 <https://chromestatus.com/feature/5117902786396160> Links to previous Intent discussions Previous I2S: Intent to Ship: Attribution Reporting API <https://groups.google.com/a/chromium.org/g/blink-dev/c/2Rmj5V6FSaY> Intent to Ship: Attribution Reporting features M117 <https://groups.google.com/a/chromium.org/g/blink-dev/c/nWF61c8xu-M/m/uMmH1ewcAQAJ> Intent to Ship: Attribution Reporting features M118 <https://groups.google.com/a/chromium.org/g/blink-dev/c/Mh-mJiyJZFk/m/HlgzpphYBQAJ> Intent to Ship: Attribution Reporting features M119 <https://groups.google.com/a/chromium.org/g/blink-dev/c/6e44SBtEtcQ> Intent to Ship: Attribution Reporting features M120 <https://groups.google.com/a/chromium.org/g/blink-dev/c/jSk3xpNPzGQ/m/VZPsdYgGCAAJ> Intent to Ship: Attribution Reporting features M121 <https://groups.google.com/a/chromium.org/g/blink-dev/c/g9KiC6Rg_mA/m/V679WcWuAQAJ> Intent to Ship: Attribution Reporting features M123 <https://groups.google.com/a/chromium.org/g/blink-dev/c/NE7VGke1Bjc/m/bIX00t4CAAAJ> --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e03cf99a-c23e-4569-b371-2c203c8f1742n%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e03cf99a-c23e-4569-b371-2c203c8f1742n%40chromium.org?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/3016b080-aa4a-4293-a370-e7827dd1d732%40gmail.com.
