LGTM2 On Wed, Apr 24, 2024 at 1:50 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote:
> LGTM1 > > Thanks for catching us up here! :) > > On Tue, Apr 23, 2024 at 10:20 AM Domenic Denicola <dome...@chromium.org> > wrote: > >> Thanks. One more thing: our process requires all features have a Finch >> feature name (i.e., a base::Feature) so that we can turn off the feature >> remotely. Can you ensure your implementation has one, and then update >> ChromeStatus with its name? >> > > Looks like a flag > <https://chromium-review.googlesource.com/c/chromium/src/+/5414853/14/third_party/blink/renderer/platform/runtime_enabled_features.json5> > is already in place, but indeed please update the chromestatus entry with > that flag's name. > > >> >> On Tue, Apr 23, 2024 at 2:29 PM Jxck <j...@chromium.org> wrote: >> >>> Thanks, I've done them. >>> >>> On Monday, April 22, 2024 at 3:53:27 PM UTC+9 Domenic Denicola wrote: >>> >>>> Can you request privacy, security, enterprise, debuggability, and >>>> testing reviews on Chrome Status? >>>> >>>> On Thu, Apr 18, 2024 at 11:36 PM Jack J <j...@chromium.org> wrote: >>>> >>>>> Contact emailsj...@chromium.org >>>>> >>>>> ExplainerNone >>>>> >>>>> Specificationhttps://url.spec.whatwg.org/#dom-url-parse >>>>> >>>>> Design docs >>>>> https://github.com/whatwg/url/pull/825 >>>>> >>>>> Summary >>>>> >>>>> Parsing url string and returning URL object. If it's invalid url >>>>> format, returning null instead of throwing Error. >>>>> >>>>> >>>>> Blink componentBlink>Network >>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ENetwork> >>>>> >>>>> Search tagsURL <https://chromestatus.com/features#tags:URL> >>>>> >>>>> TAG reviewNone >>>>> >>>>> TAG review statusNot applicable >>>>> >>>>> Risks >>>>> >>>>> >>>>> Interoperability and Compatibility >>>>> >>>>> None >>>>> >>>>> >>>>> *Gecko*: Shipped/Shipping ( >>>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1887611) >>>>> >>>>> *WebKit*: Shipped/Shipping ( >>>>> https://github.com/WebKit/WebKit/pull/26403) >>>>> >>>>> *Web developers*: Positive ( >>>>> https://github.com/denoland/deno/issues/23069) >>>>> https://github.com/nodejs/node/issues/52208 >>>>> >>>>> *Other signals*: >>>>> >>>>> WebView application risks >>>>> >>>>> Does this intent deprecate or change behavior of existing APIs, such >>>>> that it has potentially high risk for Android WebView-based applications? >>>>> >>>>> None >>>>> >>>>> >>>>> Debuggability >>>>> >>>>> None >>>>> >>>>> >>>>> Will this feature be supported on all six Blink platforms (Windows, >>>>> Mac, Linux, ChromeOS, Android, and Android WebView)?Yes >>>>> >>>>> Is this feature fully tested by web-platform-tests >>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>> ?Yes >>>>> >>>>> >>>>> https://wpt.fyi/results/url?label=master&label=experimental&aligned&q=url-statics-parse >>>>> >>>>> >>>>> Flag name on chrome://flags >>>>> chrome://flags/#enable-experimental-web-platform-features >>>>> >>>>> Finch feature nameNone >>>>> >>>>> Non-finch justificationNone >>>>> >>>>> Requires code in //chrome?False >>>>> >>>>> Tracking bughttps://issues.chromium.org/issues/331041242 >>>>> >>>>> Estimated milestones >>>>> Shipping on desktop 126 >>>>> Shipping on Android 126 >>>>> Shipping on WebView 126 >>>>> Shipping on WebView 126 >>>>> >>>>> Anticipated spec changes >>>>> >>>>> Open questions about a feature may be a source of future web compat or >>>>> interop issues. Please list open issues (e.g. links to known github issues >>>>> in the project for the feature specification) whose resolution may >>>>> introduce web compat/interop risk (e.g., changing to naming or structure >>>>> of >>>>> the API in a non-backward-compatible way). >>>>> None >>>>> >>>>> Link to entry on the Chrome Platform Status >>>>> https://chromestatus.com/feature/6301071388704768 >>>>> >>>>> This intent message was generated by Chrome Platform Status >>>>> <https://chromestatus.com/>. >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "blink-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to blink-dev+unsubscr...@chromium.org. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFBcQZ--hCtq-W37%2BkXCf89uKdEQ6Ot8RAdDO5LFXd7qReY_xw%40mail.gmail.com >>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFBcQZ--hCtq-W37%2BkXCf89uKdEQ6Ot8RAdDO5LFXd7qReY_xw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra_800vnfaubD_W4X77V21MYLgwxhYQ-oG0pH_8BuFyk4Q%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra_800vnfaubD_W4X77V21MYLgwxhYQ-oG0pH_8BuFyk4Q%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra-mEqykd-%2BSCpxnLD0uUnSox-niThehMVmE9JeANLN76g%40mail.gmail.com.
