LGTM3. It might be worth manually testing popular Japanese sites that use ruby to make sure this doesn't cause issues. But, I think it would be hard for sites to depend on specific line breaking behavior in a way that could cause breakage.
On Tue, Jun 4, 2024 at 3:53 PM Daniel Bratell <brat...@sarasas.se> wrote: > LGTM2 > > /Daniel > On 2024-06-04 04:16, TAMURA, Kent wrote: > > The test "text-wrap.tentative.html" is tentative because of > text-wrap:balance and text-wrap:pretty. I'll do: > - File a spec issue for them, and > - Make a non-tetative test for text-wrap:nowrap. > > > On Mon, Jun 3, 2024 at 5:57 PM Philip Jägenstedt <foo...@chromium.org> > wrote: > >> LGTM1 >> >> This is a change of default behavior, but the previous behavior is likely >> very rare and it can be achieved using `text-wrap: nowrap`. >> >> Since the text-wrap part is important for adoption of this, can you check >> if text-wrap.tentative.html still needs to be tentative? The test has a >> comment about Chrome support, but no link to open spec issues. >> >> On Fri, May 31, 2024 at 10:49 AM TAMURA, Kent <tk...@chromium.org> wrote: >> >>> Contact emails tk...@chromium.org >>> >>> Explainer >>> https://docs.google.com/document/d/1hzvrwoE_0aw08X_CaU40zV5bXbMQjY2SHQHj3Np4sDo/edit?pli=1#heading=h.acpilydj9j1d >>> >>> Specification https://drafts.csswg.org/css-ruby/#break-within >>> >>> Design docs >>> >>> https://docs.google.com/document/d/1hzvrwoE_0aw08X_CaU40zV5bXbMQjY2SHQHj3Np4sDo/edit?usp=sharing >>> >>> Summary >>> >>> Line-breaks are possible within elements with `display: ruby`. A single >>> pair of a ruby-base and a ruby-text has never been line-breakable, and it >>> has been pushed to the next line if the current line had no enough space >>> for the entire pair. Now each of the ruby-base and the ruby-text can be >>> split into multiple lines. >>> >>> >>> Blink component Blink>Layout>Ruby >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ELayout%3ERuby> >>> >>> Search tags ruby <https://chromestatus.com/features#tags:ruby> >>> >>> TAG review None; This is a small behavior change, and there is no API >>> to cover this behavior. >>> >>> TAG review status Not applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> Compatibility risk: * Web authors might expect rubies are not >>> line-breakable. They need to specify `text-wrap: nowrap` or something to >>> disable line-breaking if they don't want line-breaking. Interoperability >>> risk: * This would be the first implementation of the behavior. >>> >>> <ruby> appears in about 0.14% of page views [1]. Rubies with long >>> content are very rare, and this change will affect much less than 0.14% >>> page views. >>> >>> [1] https://chromestatus.com/metrics/feature/timeline/popularity/576 >>> >>> *Gecko*: No signal ( >>> https://github.com/mozilla/standards-positions/issues/1028) >>> >>> *WebKit*: Support ( >>> https://github.com/WebKit/standards-positions/issues/232) It seems the >>> latest Safari has implemented line-breakable ruby partially. >>> >>> *Web developers*: Positive ( >>> https://docs.google.com/document/d/1hzvrwoE_0aw08X_CaU40zV5bXbMQjY2SHQHj3Np4sDo/edit?pli=1#heading=h.giqn8tqur4ig >>> ) >>> >>> *Other signals*: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> None >>> >>> >>> Debuggability >>> >>> Existing DevTools functionalities are enough. >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)? Yes >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? Yes >>> >>> https://wpt.fyi/results/css/css-ruby/break-within-bases >>> >>> >>> Flag name on chrome://flags enable-experimental-web-platform-features >>> >>> Finch feature name RubyLineBreakable >>> >>> Requires code in //chrome? False >>> >>> Tracking bug https://issues.chromium.org/issues/324111880 >>> >>> Estimated milestones >>> Shipping on desktop 128 >>> DevTrial on desktop 127 >>> Shipping on Android 128 >>> DevTrial on Android 127 >>> Shipping on WebView 128 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> None >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/5077282711666688 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> >>> >>> -- >>> TAMURA Kent >>> Software Engineer, Google >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGSv71qaDAHEmo-%3D_kbx6ywT7bBW8MyJR-YyZX4Xp42yA%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGSv71qaDAHEmo-%3D_kbx6ywT7bBW8MyJR-YyZX4Xp42yA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> > > -- > TAMURA Kent > Software Engineer, Google > > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqH3W_8D8xYpEXM8%3DiGnks8WUsrMh0GD2b9ctcBFqs8fYA%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqH3W_8D8xYpEXM8%3DiGnks8WUsrMh0GD2b9ctcBFqs8fYA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/50c1386d-9b8f-44ca-9536-5e03cb9af613%40sarasas.se > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/50c1386d-9b8f-44ca-9536-5e03cb9af613%40sarasas.se?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra_CcygOJhnW09Yi%2BJcCuO2cO%3D86A3hF6B%2BuY-MW1%2BtVCA%40mail.gmail.com.