Thanks - LGTM1
On 6/24/24 11:02 AM, Raphael Kubo da Costa wrote:
Done!
Mike Taylor <miketa...@chromium.org> writes:
Could you please request reviews for the various review gate bits in
your chromestatus entry?
(privacy, security, enterprise... etc)
On 6/19/24 3:54 AM, Mandy, Arnaud wrote:
Contact emails
raphael.kubo.da.co...@intel.com
<mailto:raphael.kubo.da.co...@intel.com>, juha.j.vai...@intel.com
<mailto:juha.j.vai...@intel.com>, kenneth.r.christian...@intel.com
<mailto:kenneth.r.christian...@intel.com>, arnaud.ma...@intel.com
<mailto:arnaud.ma...@intel.com>
Specification
https://github.com/w3c/compute-pressure/pull/284
<https://github.com/w3c/compute-pressure/pull/284>
Summary
This exposes WebDriver commands for creating, removing and updating
pressure source samples for so-called "virtual pressure sources":
pressure sources that do not depend on underlying hardware or
operating system support and can be used for testing.
Not only does this allow ChromeDriver users to test this API more
easily, but it was also one of the suggestions brought up during the
Intent to Ship thread for this API
<https://groups.google.com/a/chromium.org/g/blink-dev/c/7leKysvPZWk/m/MEtDE7zyAQAJ>,
as the existing web tests in WPT depend on MojoJS and are not
interoperable.
Blink component
Blink>PerformanceAPIs>ComputePressure
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EPerformanceAPIs%3EComputePressure>
TAG review
None
TAG review status
Not applicable
Risks
Interoperability and Compatibility
This feature implements WebDriver extension commands in ChromeDriver
that are used in web-platform-tests and can also be used by
ChromeDriver users. This feature is therefore not web-exposed, but
it does intend to help increase adoption of the spec by making it
possible for any implementation to run the existing web tests
without having to use JS mocks that are heavily Mojo-based although
not dependent on Mojo.
/Gecko/: No signal for this feature (Not in favor of Compute Pressure API)
/WebKit/: No signal for this feature (Not in favor of Compute
Pressure API)
/Web developers/: No signals
/Other signals/: Compute Pressure API Intent To Ship comment
<https://groups.google.com/a/chromium.org/g/blink-dev/c/7leKysvPZWk/m/MEtDE7zyAQAJ>.
Security
n/a, this is exposed through WebDriver. There have been changes to
the Compute Pressure code in //content and //services.
WebView application risks
None, this API is not exposed on Android.
Ongoing technical constraints
WebDriver endpoints and virtual pressure sources work in Window and
Dedicated Worker scopes, but not shared worker ones: we store
virtual pressure source information in WebContentsUserData, which
does not integrate well with shared workers. Shared worker support
would need to work with origins instead, but doing so would not play
well with any DevTools frontend work to support the Compute Pressure
API. The same constraint is also present in the spec, and feedback
is being gathered in issue 285
<https://github.com/w3c/compute-pressure/issues/285>.
Debuggability
This is a debugging feature. It exposes new ChromeDriver and CDP
endpoints, but the DevTools frontend has not been touched.
Will this feature be supported on all six Blink platforms (Windows,
Mac, Linux, ChromeOS, Android, and Android WebView)?
Windows, Mac, Linux, ChromeOS
Is this feature fully tested by web-platform-tests
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?
The feature is currently tested by WPT, but the tests depend on
Mojo-specific JS mocks. Having these endpoints is the first step
towards making the existing web tests interoperable.
Requires code in //chrome?
True: //chrome/test/chromedriver
Tracking bug
https://issues.chromium.org/u/1/issues/347031400
<https://issues.chromium.org/u/1/issues/347031400>
Estimated milestones
Shipping on desktop 130
Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5130657352384512
<https://chromestatus.com/feature/5130657352384512>
-- You received this message because you are subscribed to the
Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/DS0PR11MB79029DDFA8D49E3C82BEAF4393CF2%40DS0PR11MB7902.namprd11.prod.outlook.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/DS0PR11MB79029DDFA8D49E3C82BEAF4393CF2%40DS0PR11MB7902.namprd11.prod.outlook.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/97a48e59-eefb-49bc-897c-06805d522990%40chromium.org.
