Hi all, thanks for all the reviewings and LGTMs. On Wednesday, July 24, 2024 at 2:27:58 PM UTC+8 dom...@chromium.org wrote:
> LGTM3 > > On Wed, Jul 24, 2024 at 10:07 AM TAMURA, Kent <tk...@chromium.org> wrote: > >> LGTM2. >> >> >> On Wed, Jul 24, 2024 at 1:19 AM Vladimir Levin <vmp...@chromium.org> >> wrote: >> >>> >>> >>> On Tue, Jul 23, 2024 at 3:08 AM Shuangshuang Zhou <shuangsh...@intel.com> >>> wrote: >>> >>>> Contact emailsshuangsh...@intel.com >>>> >>>> ExplainerNone >>>> >>>> Specification >>>> https://w3c.github.io/selection-api/#scheduling-selectionhange-event >>>> >>>> Summary >>>> >>>> This feature is not to fire selectionchange event when there is already >>>> one pending. For web developers, selectionchange event listeners will be >>>> called less often with this feature. Before this feature, every time the >>>> mutation of the selection on one target(input/textarea/document) would >>>> make >>>> the listener to be called once. >>>> >>>> Now with this feature, before the selectionchange event listner is >>>> finally called, multiple mutations of the selection on one target would >>>> make the listener to be called only once. >>>> >>>> >>>> Blink componentBlink>Editing>Selection >>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EEditing%3ESelection> >>>> >>>> TAG reviewNone >>>> >>>> TAG review statusIssues addressed >>>> >>>> Risks >>>> >>>> >>>> Interoperability and Compatibility >>>> >>>> Interoperability risk is low because Firefox and Safari have shipped >>>> this according to the specification. It has none compatibility risk since >>>> this is nor a removal. W3C spec for this feature: >>>> https://w3c.github.io/selection-api/#scheduling-selectionhange-event >>>> >>> >>> This is a fairly recent spec change, but it seems like it has support >>> from other vendors. From reading the discussion on the issue ( >>> https://github.com/w3c/selection-api/issues/170), I think the impact to >>> existing developer expectations is minimal. >>> >>> LGTM1 >>> >>> >>>> >>>> *Gecko*: Shipped/Shipping ( >>>> https://hg.mozilla.org/integration/autoland/rev/6632631a15ec) >>>> >>>> *WebKit*: Shipped/Shipping (https://commits.webkit.org/276388@main) >>>> This feature is shipped in Safari Technology Preview. >>>> >>>> *Web developers*: No signals >>>> >>>> *Other signals*: >>>> >>>> WebView application risks >>>> >>>> Does this intent deprecate or change behavior of existing APIs, such >>>> that it has potentially high risk for Android WebView-based applications? >>>> >>>> Low WebView application risks. >>>> >>>> >>>> Debuggability >>>> >>>> None >>>> >>>> >>>> Will this feature be supported on all six Blink platforms (Windows, >>>> Mac, Linux, ChromeOS, Android, and Android WebView)?Yes >>>> >>>> Is this feature fully tested by web-platform-tests >>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>> ?Yes >>>> >>>> Some related WPT tests results have been updated in our commit. Commit >>>> url: https://chromium-review.googlesource.com/c/chromium/src/+/5494116 >>>> Related wpt tests(all passed in the try job): >>>> *third_party/blink/web_tests/external/wpt/selection/onselectionchange-on-distinct-text-controls.html >>>> >>>> *third_party/blink/web_tests/external/wpt/selection/onselectionchange-on-document.html >>>> >>>> *third_party/blink/web_tests/external/wpt/selection/onselectionchange-on-document.html >>>> >>>> *third_party/blink/web_tests/external/wpt/selection/textcontrols/selectionchange.html >>>> >>>> *third_party/blink/web_tests/external/wpt/selection/textcontrols/selectionchange-on-shadow-dom.html >>>> >>>> *third_party/blink/web_tests/fast/events/selectionchange-iframe.html >>>> >>>> >>>> On latest wpt.fyi, the tests are all passed, see: >>>> >>>> >>>> https://wpt.fyi/results/selection/onselectionchange-on-document.html?label=experimental&label=master&aligned >>>> >>>> Flag name on chrome://flagsNone >>>> >>>> Finch feature nameCoalesceSelectionchangeEvent >>>> >>>> Requires code in //chrome?False >>>> >>>> Estimated milestones >>>> Shipping on desktop >>>> 128 >>>> >>>> Anticipated spec changes >>>> >>>> Open questions about a feature may be a source of future web compat or >>>> interop issues. Please list open issues (e.g. links to known github issues >>>> in the project for the feature specification) whose resolution may >>>> introduce web compat/interop risk (e.g., changing to naming or structure >>>> of >>>> the API in a non-backward-compatible way). >>>> None >>>> >>>> Link to entry on the Chrome Platform Status >>>> https://chromestatus.com/feature/5227302221512704?gate=5124056542871552 >>>> >>>> Links to previous Intent discussions >>>> >>>> This intent message was generated by Chrome Platform Status >>>> <https://chromestatus.com/>. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/58462a23-205f-471c-aaf1-b2493d4ee471n%40chromium.org >>>> >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/58462a23-205f-471c-aaf1-b2493d4ee471n%40chromium.org?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2MFjpZV05WDgudUpwvJDZ5bho1DJJenhxP%2BVouOv5wLBQ%40mail.gmail.com >>> >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2MFjpZV05WDgudUpwvJDZ5bho1DJJenhxP%2BVouOv5wLBQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> >> -- >> TAMURA Kent >> Software Engineer, Google >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+...@chromium.org. >> > To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqFHgMvjGkgNwuS8XF1ahHBxyaUaj-Y8NaNCJAVLpQ4SVA%40mail.gmail.com >> >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqFHgMvjGkgNwuS8XF1ahHBxyaUaj-Y8NaNCJAVLpQ4SVA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/432c30d7-bc02-4019-b610-9a2c3b041ab5n%40chromium.org.
