LGTM3

On 11/6/24 11:21 AM, Chris Harrelson wrote:
LGTM2

On Wed, Nov 6, 2024 at 7:26 AM Yoav Weiss (@Shopify) <yoavwe...@chromium.org> wrote:

    LGTM1

    On Thursday, October 31, 2024 at 9:22:02 PM UTC+1 Cammie Smith
    Barnes wrote:

        Intent to Ship: Saved queries in sharedStorage.selectURL

        Contact emails

        cam...@chromium.org, yao...@chromium.org,
        jkar...@chromium.org, rohitgu...@chromium.org,
        rohitgu...@chromium.org, ren...@google.com, saraak...@google.com


        Explainer

        https://github.com/WICG/shared-storage/pull/176
        <https://github.com/WICG/shared-storage/pull/176>


    A few lines of inline explanation and/or copy/pasting the example
    from the final explainer would have been better than pointing at a
    PR diff..


        Specification

        https://github.com/WICG/shared-storage/pull/188
        <https://github.com/WICG/shared-storage/pull/188>

        https://github.com/WICG/shared-storage/pull/202
        <https://github.com/WICG/shared-storage/pull/202>


        Summary

        Until fenced frames are required for selectURL, we have a
        per-page limit on its usage. This is limiting for callers as
        they can only use it twice per page load. This savedQuery
        option allows for selectURL() to be called any number of times
        across a page, and will always return the same value for the
        same query name. This is helpful for callers that are looking
        for consistent behavior based on cross-site information (e.g.,
        cross-site a/b experiment selection).


        Blink component

        Blink>Storage>SharedStorage
        
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EStorage%3ESharedStorage>


        TAG review

        Review
        
<https://github.com/w3ctag/design-reviews/issues/747#issuecomment-2404927488>


        TAG review status

        TAG is unsatisfied
        <https://github.com/w3ctag/design-reviews/issues/747>with the
        underlying API


        Risks

        Interoperability and Compatibility

        This is a backwards compatible change.



        Gecko: Negative toward the selectURL API


        WebKit: Negative toward the selectURL API


        Web developers: Developers have been asking
        <https://github.com/WICG/shared-storage/issues/140>for this,
        as it allows them to use selectURL more frequently on a page
        without any privacy impact.


        Other signals:


        WebView application risks

        Does this intent deprecate or change behavior of existing
        APIs, such that it has potentially high risk for Android
        WebView-based applications?

        None



        Debuggability

        We intend to surface the per page load Shared Storage budgets
        in DevTools in a similar manner to the way that Shared
        Storage's navigation budget for Fenced Frames is surfaced on
        an origin's Application > Storage > Shared Storage page. This
        would allow developers, when testing locally, to confirm that
        budgets were charged as expected for saved queries. We may
        also consider including the per-page saved queries in devtools
        as well. We plan to start implementation of these features soon.




        Will this feature be supported on all six Blink platforms
        (Windows, Mac, Linux, ChromeOS, Android, and Android WebView)?

        All but WebView


        Is this feature fully tested by web-platform-tests
        
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?


        Yes


        Flag name on chrome://flags

        None


        Finch feature name

        SharedStorageSelectURLSavedQueries


        Requires code in //chrome?

        False


        Tracking bug

        https://issues.chromium.org/u/1/issues/367440966
        <https://issues.chromium.org/u/1/issues/367440966>


        Launch bug

        https://launch.corp.google.com/launch/4346722
        <https://launch.corp.google.com/launch/4346722>


        Estimated milestones

        Shipping on desktop

        132

        Shipping on Android

        132



        Anticipated spec changes

        Open questions about a feature may be a source of future web
        compat or interop issues. Please list open issues (e.g. links
        to known github issues in the project for the feature
        specification) whose resolution may introduce web
        compat/interop risk (e.g., changing to naming or structure of
        the API in a non-backward-compatible way).

        None


        Link to entry on the Chrome Platform Status

        https://chromestatus.com/feature/5098690386329600?gate=5084801233846272
        
<https://chromestatus.com/feature/5098690386329600?gate=5084801233846272>


        This intent message was generated by Chrome Platform Status
        <https://chromestatus.com/>.


-- You received this message because you are subscribed to the Google
    Groups "blink-dev" group.
    To unsubscribe from this group and stop receiving emails from it,
    send an email to blink-dev+unsubscr...@chromium.org.
    To view this discussion visit
    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f2698444-0b26-4e75-8803-f7491a0594e1n%40chromium.org
    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f2698444-0b26-4e75-8803-f7491a0594e1n%40chromium.org?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-SZ2hh33jUaia7RGs9by%3DDxK_-zLBva%2Bon0uQ2jryuqw%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-SZ2hh33jUaia7RGs9by%3DDxK_-zLBva%2Bon0uQ2jryuqw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ab358f28-48ee-4b11-9e91-f719827da561%40chromium.org.

Reply via email to