They should really just be in sync. We have not discussed if one of them is more canon than the other.

Alex, just missing a mail for your lgtm?

/Daniel

On 2024-11-12 20:45, Daniel Clark wrote:

In https://chromestatus.com/feature/4926138582040576?gate=4779038837833728 I see that 3 API Owners are marked as having approved, but in this thread there are only two votes.

I assume that it’s this thread that should be treated as the source of truth (is that right?), but maybe Alex can clarify if he meant to record an LGTM here as well?

-- Dan

*From:*Domenic Denicola <dome...@chromium.org>
*Sent:* Wednesday, October 30, 2024 11:06 PM
*To:* blink-dev <blink-dev@chromium.org>
*Cc:* Samba Murthy Bandaru <sambamurthy.band...@microsoft.com>; Yoav Weiss <yoavwe...@chromium.org>; Chromestatus <ad...@cr-status.appspotmail.com>; blin...@chromium.org <blink-dev@chromium.org>; Rakesh Goulikar <rakesh.gouli...@microsoft.com>; Sanket Joshi (EDGE) <sa...@microsoft.com>; Daniel Bratell <bratel...@gmail.com> *Subject:* Re: [blink-dev] Intent to Ship: Support creating ClipboardItem with Promise<DOMString>

LGTM2.

I agree with Daniel's comments that a couple sentences of explainer would have helped here.

Note that the WPTs are showing as failing on wpt.fyi because your CL <https://chromium-review.googlesource.com/c/chromium/src/+/5759427> marked the new feature as "test" instead of "experimental". This is fine, but in the future it's slightly nicer if you mark them as "experimental". Since wpt.fyi runs in experimental mode, that lets us verify that the tests are passing a bit more easily.

On Thursday, October 31, 2024 at 3:04:33 AM UTC+9 Sambamurthy Bandaru wrote:

    Done.

    On Wednesday, October 30, 2024 at 3:50:25 PM UTC+5:30 Yoav Weiss
    (@Shopify) wrote:

        Can y'all flip the review bits in the chromestatus entry?

        On Fri, Oct 25, 2024 at 11:22 AM Daniel Bratell
        <brat...@gmail.com> wrote:

            LGTM1 - but I do have some comments.

            It's good catching up here, but I recommend always to
            write an explainer. For a trivial change, it might be a
            trivial explainer, but just something for those that are
            not intimately familiar with the area. Might just be a one
            or a few sentences. And it's not too late.

            I see that Chromium currently also fails the DOMString
            test without promises, but with a Promise error so that
            test may be buggy.

            /Daniel

            On 2024-10-24 12:08, Chromestatus wrote:


                        Contact emails

                sambamurt...@microsoft.com, rago...@microsoft.com,
                sa...@microsoft.com


                        Explainer

                None


                        Specification

                
https://www.w3.org/TR/clipboard-apis/#typedefdef-clipboarditemdata



                        Summary

                The ClipboardItem, which is the input to the async
                clipboard write method, now accepts string values in
                addition to Blobs in its constructor.
                ClipboardItemData can be a Blob, a string, or a
                Promise that resolves to either a Blob or a string.


                        Blink component

                Blink>DataTransfer
                
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EDataTransfer>



                        TAG review

                None


                        TAG review status

                Not applicable


                        Risks


                        Interoperability and Compatibility

                This is already supported in Firefox and Safari



                /Gecko/: Shipped/Shipping
                
(https://developer.mozilla.org/en-US/docs/Web/API/ClipboardItem/ClipboardItem#data)


                /WebKit/: Shipped/Shipping
                (https://webkit.org/blog/10855/async-clipboard-api)

                /Web developers/: No signals

                /Other signals/:


                        WebView application risks

                /Does this intent deprecate or change behavior of
                existing APIs, such that it has potentially high risk
                for Android WebView-based applications?/

                None


                        Debuggability

                None


                        Will this feature be supported on all six
                        Blink platforms (Windows, Mac, Linux,
                        ChromeOS, Android, and Android WebView)?

                Yes


                        Is this feature fully tested by
                        web-platform-tests
                        
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

                Yes

                
https://wpt.fyi/results/clipboard-apis/async-navigator-clipboard-basics.https.html


                        Flag name on chrome://flags

                None


                        Finch feature name

                ClipboardItemWithDOMStringSupport


                        Requires code in //chrome?

                False


                        Tracking bug

                https://issues.chromium.org/issues/40766145


                        Estimated milestones

                DevTrial on desktop

                        

                132

                DevTrial on Android

                        

                132

                DevTrial on iOS

                        

                132


                        Anticipated spec changes

                /Open questions about a feature may be a source of
                future web compat or interop issues. Please list open
                issues (e.g. links to known github issues in the
                project for the feature specification) whose
                resolution may introduce web compat/interop risk
                (e.g., changing to naming or structure of the API in a
                non-backward-compatible way)./

                None


                        Link to entry on the Chrome Platform Status

                
https://chromestatus.com/feature/4926138582040576?gate=4779038837833728


                This intent message was generated by Chrome Platform
                Status <https://chromestatus.com/>.

-- You received this message because you are subscribed
                to the Google Groups "blink-dev" group.

                To unsubscribe from this group and stop receiving
                emails from it, send an email to
                blink-dev+...@chromium.org.


                To view this discussion visit
                
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/671a1c83.710a0220.3c7610.03ef.GAE%40google.com
                
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/671a1c83.710a0220.3c7610.03ef.GAE%40google.com?utm_medium=email&utm_source=footer>.

-- You received this message because you are subscribed to
            the Google Groups "blink-dev" group.

            To unsubscribe from this group and stop receiving emails
            from it, send an email to blink-dev+...@chromium.org.

            To view this discussion visit
            
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/702e53aa-c46f-4eef-a8fb-a664d2fc9c27%40gmail.com
            
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/702e53aa-c46f-4eef-a8fb-a664d2fc9c27%40gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/d936d61d-580a-4f19-85bd-83409589b80en%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/d936d61d-580a-4f19-85bd-83409589b80en%40chromium.org?utm_medium=email&utm_source=footer>.


--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/cd69e1ea-b233-4748-9b8b-cd450cb4a030%40gmail.com.

Reply via email to