LGTM2.
Maybe toss something like
assert_true(CSS.supports('selector(::view-transition)')) somewhere and
call it a day.
On 3/5/25 11:19 AM, Chris Harrelson wrote:
LGTM1
It'd be good to improve the tests.
On Mon, Mar 3, 2025 at 12:47 AM Noam Rosenthal
<nrosent...@chromium.org> wrote:
On Fri, Feb 28, 2025 at 10:18 PM 'Dan Clark' via blink-dev
<blink-dev@chromium.org> wrote:
Something about the WPT results was surprising to me. It looks
like Firefox is passing all of them, even in stable
(https://wpt.fyi/results/css/css-view-transitions/nested?label=master&label=stable&aligned
<https://wpt.fyi/results/css/css-view-transitions/nested?label=master&label=stable&aligned>),
despite not having shipped view transitions more generally
yet:
https://wpt.fyi/results/css/css-view-transitions?label=master&label=experimental&view=interop&q=label%3Ainterop-2025-view-transitions
<https://wpt.fyi/results/css/css-view-transitions?label=master&label=experimental&view=interop&q=label%3Ainterop-2025-view-transitions>.
I'm pretty sure Firefox hasn't shipped this, so is there an
issue with the tests?
Yea, those tests pass when there is no view-transition support at
all and fail when there is view-transition support without this
additional feature on top.
They could definitely be improved to avoid this confusion.
I don't think this is material for the interoperability for this
feature as no one would implement this before implementing classic
flat view transition groups, but it should also be a simple fix to
the tests.
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to blink-dev+unsubscr...@chromium.org.
To view this discussion visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJn%3DMYa0Q1%2BX6vj8mBU3ne6sJbUxRF7%3Dx7Ye6CYxDd_egVONGQ%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJn%3DMYa0Q1%2BX6vj8mBU3ne6sJbUxRF7%3Dx7Ye6CYxDd_egVONGQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to blink-dev+unsubscr...@chromium.org.
To view this discussion visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9e40kSnTzFKr196%3D655yrwQ5U2eaBysGED2KvQBXdF_Q%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9e40kSnTzFKr196%3D655yrwQ5U2eaBysGED2KvQBXdF_Q%40mail.gmail.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/da80ff44-d0bd-4c32-b8de-7106852c00d9%40chromium.org.
