LGTM2

On 6/12/25 9:54 PM, Domenic Denicola wrote:
LGTM1

On Friday, June 13, 2025 at 1:27:32 AM UTC+9 Sneha Agarwal wrote:

    Contact emails
    snehagar...@microsoft.com, stev...@microsoft.com

    Explainer
    None


Note that the feature is somewhat documented at https://developer.mozilla.org/en-US/docs/Web/API/ReadableStreamBYOBReader/read . A more detailed explainer with alternatives considered, etc., would have been nice, but I don't think making you write one as the second implementer is necessary.

For those interested, the spec PR <https://github.com/whatwg/streams/pull/1145> which added this contains some discussion and links to relevant issues, especially this one <https://github.com/whatwg/streams/issues/1175>. There's a lot of specification details discussion mixed in as well, but people can find the design discussion too.



    Specification
    https://streams.spec.whatwg.org/#byob-reader-read
    <https://streams.spec.whatwg.org/#byob-reader-read>

    Summary

    This feature introduces a min option to the existing
    ReadableStreamBYOBReader.read(view) API. The API already accepts a
    ArrayBufferView into which data is read, but currently does not
    guarantee how many elements will be written before the read
    resolves. The min option is an additive, opt-in enhancement - it
    does not affect existing behavior for applications that don’t use
    it. By specifying a min value, developers can require that the
    stream wait until at least that many elements are available before
    resolving the read. This improves upon the current behavior, where
    reads may resolve with fewer elements than the view can hold.



    Blink component
    Blink>Network>StreamsAPI
    
<https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3ENetwork%3EStreamsAPI%22>

    Search tags
    streamsAPI <https://chromestatus.com/features#tags:streamsAPI>,
    BYOB <https://chromestatus.com/features#tags:BYOB>,
    ReadableStreamBYOBReader
    <https://chromestatus.com/features#tags:ReadableStreamBYOBReader>

    TAG review
    None

    TAG review status
    Not applicable

    Risks


    Interoperability and Compatibility

    None



    /Gecko/: Positive
    (https://bugzilla.mozilla.org/show_bug.cgi?id=1864406
    <https://bugzilla.mozilla.org/show_bug.cgi?id=1864406>) Feature
    shipped in 134

    /WebKit/: No signal


Note that while "No signal" is the correct way of filling out this field, since there's no official standards position, we have a public statement on the spec PR that "WebKit supports this addition" <https://github.com/whatwg/streams/pull/1145#issuecomment-1582499354>. Combined with the WebKit bug <https://bugs.webkit.org/show_bug.cgi?id=264731> on file for implementing this, I think it is reasonable to approve this without requiring a formal standards position.


    /Web developers/: Positive Developers requested this feature in
    Chromium https://issues.chromium.org/issues/40942083
    <https://issues.chromium.org/issues/40942083> ,
    https://issues.chromium.org/issues/383158935
    <https://issues.chromium.org/issues/383158935>

    /Other signals/: None

    WebView application risks

    /Does this intent deprecate or change behavior of existing APIs,
    such that it has potentially high risk for Android WebView-based
    applications?/

    None



    Debuggability

    None



    Will this feature be supported on all six Blink platforms
    (Windows, Mac, Linux, ChromeOS, Android, and Android WebView)?
    Yes

    Is this feature fully tested by web-platform-tests
    
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

    Yes

    Flag name on about://flags
    N/A

    Finch feature name
    ReadableStreamBYOBReaderReadMinOption

    Rollout plan
    Will ship enabled for all users

    Requires code in //chrome?
    False

    Tracking bug
    https://issues.chromium.org/u/0/issues/40942083?pli=1
    <https://issues.chromium.org/u/0/issues/40942083?pli=1>

    Estimated milestones
    Shipping on desktop
    140
    Shipping on Android
    140
    Shipping on WebView
    140


    Anticipated spec changes

    /Open questions about a feature may be a source of future web
    compat or interop issues. Please list open issues (e.g. links to
    known github issues in the project for the feature specification)
    whose resolution may introduce web compat/interop risk (e.g.,
    changing to naming or structure of the API in a
    non-backward-compatible way)./

    None

    Link to entry on the Chrome Platform Status
    https://chromestatus.com/feature/6396991665602560?gate=6377960329969664
    <https://chromestatus.com/feature/6396991665602560?gate=6377960329969664>

    This intent message was generated by Chrome Platform Status
    <https://chromestatus.com/>.


--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/1ed24046-808f-4d53-97c0-e95d2a7befb7n%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/1ed24046-808f-4d53-97c0-e95d2a7befb7n%40chromium.org?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8ba1c8e5-4c05-4fd5-ad98-877415ef4fe9%40chromium.org.

Reply via email to