Great, thank you! On Fri, Jun 27, 2025 at 5:12 AM Chris Harrelson <chris...@chromium.org> wrote:
> The commit method was part of the original OffscreenCanvas design, and > based on feedback it was removed (lots of discussion in this thread > <https://groups.google.com/a/chromium.org/g/blink-dev/c/hRZ_P2o-aEk/m/oPEmHWFLAwAJ?e=48417069>). > It's safe to remove this method and the flag. > > On Thu, Jun 26, 2025 at 6:36 PM Domenic Denicola <dome...@chromium.org> > wrote: > >> That PR did not cover WebGLRenderingContext; it only >> modified OffscreenCanvasRenderingContext2D. >> >> The WebGLRenderingContextBase interface seems to be specified in >> https://registry.khronos.org/webgl/specs/latest/1.0/#5.14 . I can't find >> the word "commit" in that spec using find-in-page, at least. >> >> On Thu, Jun 26, 2025 at 11:04 PM Dave Tapuska <dtapu...@chromium.org> >> wrote: >> >>> I'd leave that to Domenic to comment (since they reviewed the PR) :-) >>> >>> >>> On Thu, Jun 26, 2025 at 9:58 AM Colin Blundell <blund...@chromium.org> >>> wrote: >>> >>>> >>>> >>>> On Thu, Jun 26, 2025 at 3:53 PM Dave Tapuska <dtapu...@chromium.org> >>>> wrote: >>>> >>>>> Features behind experimental web platform flags are considered >>>>> experimental and can be removed. There doesn't appear to be a field trial >>>>> for this either. So I believe it is fine to remove. My guess is that it >>>>> should have been removed when the 2d version was removed. See >>>>> https://source.chromium.org/chromium/chromium/src/+/6905991000c1950addd7b980604d453b5bcf26a7 >>>>> >>>> >>>> Thanks for that pointer! In particular, am I reading correctly that this >>>> PR <https://github.com/whatwg/html/pull/9979> covered the WebGL >>>> context? >>>> >>>> >>>>> >>>>> dave. >>>>> >>>>> On Thu, Jun 26, 2025 at 3:00 AM Colin Blundell <blund...@chromium.org> >>>>> wrote: >>>>> >>>>>> Hi +Chris Harrelson <chris...@google.com> and blink-dev@, >>>>>> >>>>>> +Vasiliy Telezhnikov <vtelezhni...@google.com> and I discovered that >>>>>> WebGLRenderingContextBase::commit() appears to implement an abandoned >>>>>> web API >>>>>> <https://udn.realityripple.com/docs/Web/API/WebGLRenderingContext/commit#:~:text=The%20WebGLRenderingContext%20.,fixed%20to%20a%20specific%20canvas.> >>>>>> (it's >>>>>> under an experimental runtime flag >>>>>> <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.idl;drc=7616db6075ca98a67eb13b268e23f05ddd8cf342;l=720> >>>>>> that >>>>>> was added years ago >>>>>> <https://chromium-review.googlesource.com/c/chromium/src/+/1131221>). >>>>>> However, we're not web platform experts. Could anyone say definitively >>>>>> whether it's safe to remove this code? >>>>>> >>>>>> Thanks, >>>>>> >>>>>> Colin >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "blink-dev" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>> To view this discussion visit >>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMGE5NGBDXAsBodEhNEi_15FOWc%2BTEU6a0%3DiBw_XiDaUmC-z6g%40mail.gmail.com >>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMGE5NGBDXAsBodEhNEi_15FOWc%2BTEU6a0%3DiBw_XiDaUmC-z6g%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMGE5NEVU6rEWQrLJjMTEdFBzy5fGef9HV7GbCK6vE7jTtaoVw%40mail.gmail.com.
