LGTM3

On 7/7/25 2:15 p.m., Alex Russell wrote:
LGTM2

On Sunday, July 6, 2025 at 10:51:50 PM UTC-7 sejal...@microsoft.com wrote:



    Thank you Philip for your approval, font-variation-settings CL is
    also merged, I'll ship both of them together.


    ------------------------------------------------------------------------
    *From:* Philip Jägenstedt <foo...@chromium.org>
    *Sent:* Saturday, July 5, 2025 1:54 PM
    *To:* Chromestatus <ad...@cr-status.appspotmail.com
    <mailto:ad...@cr-status.appspotmail.com>>
    *Cc:* blink-dev@chromium.org <blink-dev@chromium.org>; Ragvesh
    Sharma's Organization (FTE) <ragvesh_org_...@microsoft.com>
    *Subject:* [EXTERNAL] Re: [blink-dev] Intent to Ship: Support
    font-feature-settings descriptor in @font-face rule
    LGTM1, thank you for addressing this pain point for developers!

    The scope of this intent is font-feature-settings, but now that
    https://chromium-review.googlesource.com/c/chromium/src/+/6582382
    <https://chromium-review.googlesource.com/c/chromium/src/+/6582382>
    has been merged, do you want to ship support
    for font-feature-settings and font-variation-settings together? I
    think that would be great, but my LGTM is not conditional on it.

    I also confirmed that the linked tests are failing on stable but
    passing on experimental, so everything seems to be in good order!

    On Thu, Jul 3, 2025 at 4:53 AM Chromestatus
    <ad...@cr-status.appspotmail.com
    <mailto:ad...@cr-status.appspotmail.com>> wrote:


                Contact emails

        sejalan...@microsoft.com


                Explainer

        None


                Specification

        https://www.w3.org/TR/css-fonts-4/#font-rend-desc
        <https://www.w3.org/TR/css-fonts-4/#font-rend-desc>


                Summary

        As CSS allows fine control over font features using
        'font-feature-settings' at the element level, Chromium-based
        browsers currently lack support for these properties within
        '@font-face' declarations. This feature supports the
        string-based syntax for font-feature-settings as defined in
        CSS Fonts Level 4. Invalid or unrecognized feature tags will
        be ignored per specification. No binary or non-standard forms
        are supported. As OpenType fonts become more widely adopted,
        this enhancement will improve typographic control, reduce
        redundancy, and support a more scalable, modern approach to
        web design.



                Blink component

        Blink>Fonts
        
<https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3EFonts%22>



                TAG review

        None


                TAG review status

        Not applicable


                Risks



                Interoperability and Compatibility



        /Gecko/: Shipped/Shipping
        (https://bugzilla.mozilla.org/show_bug.cgi?id=1355366
        <https://bugzilla.mozilla.org/show_bug.cgi?id=1355366>)

        /WebKit/: Shipped/Shipping
        (https://bugs.webkit.org/show_bug.cgi?id=63618
        <https://bugs.webkit.org/show_bug.cgi?id=63618>)

        /Web developers/: Positive
        
(https://stackoverflow.com/questions/27486680/how-to-set-default-font-feature-settings
        
<https://stackoverflow.com/questions/27486680/how-to-set-default-font-feature-settings>)
        Over 30 users have indicated that they are affected by this
        issue and its related duplicates, as noted in
        https://issues.chromium.org/issues/40398871
        <https://issues.chromium.org/issues/40398871> and
        https://issues.chromium.org/issues/324519293
        <https://issues.chromium.org/issues/324519293>

        /Other signals/:


                WebView application risks

        Does this intent deprecate or change behavior of existing
        APIs, such that it has potentially high risk for Android
        WebView-based applications?

        None



                Debuggability

        Existing DevTools capabilities already cover this.



                Will this feature be supported on all six Blink
                platforms (Windows, Mac, Linux, ChromeOS, Android, and
                Android WebView)?

        Yes


                Is this feature fully tested by web-platform-tests
                
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

        Yes

        
https://wpt.fyi/results/css/css-fonts/font-feature-settings-descriptor-02.html?label=master&label=experimental&aligned
        
<https://wpt.fyi/results/css/css-fonts/font-feature-settings-descriptor-02.html?label=master&label=experimental&aligned>
        
https://wpt.fyi/results/css/css-fonts?label=master&label=experimental&aligned&q=font-feature-settings-descriptor-binary.html
        
<https://wpt.fyi/results/css/css-fonts?label=master&label=experimental&aligned&q=font-feature-settings-descriptor-binary.html>



                Flag name on about://flags



                Finch feature name

        FontFeatureSettingsDescriptor


                Rollout plan

        Will ship enabled for all users


                Requires code in //chrome?

        False


                Tracking bug

        https://issues.chromium.org/issues/40398871
        <https://issues.chromium.org/issues/40398871>


                Estimated milestones

        Shipping on desktop     139
        Shipping on Android     139
        Shipping on WebView     139
        Shipping on iOS         139



                Anticipated spec changes

        Open questions about a feature may be a source of future web
        compat or interop issues. Please list open issues (e.g. links
        to known github issues in the project for the feature
        specification) whose resolution may introduce web
        compat/interop risk (e.g., changing to naming or structure of
        the API in a non-backward-compatible way).

        None


                Link to entry on the Chrome Platform Status

        https://chromestatus.com/feature/5102801981800448?gate=5197421990379520
        
<https://chromestatus.com/feature/5102801981800448?gate=5197421990379520>


        This intent message was generated by Chrome Platform Status
        <https://chromestatus.com/>.
-- You received this message because you are subscribed to the
        Google Groups "blink-dev" group.
        To unsubscribe from this group and stop receiving emails from
        it, send an email to blink-dev+unsubscr...@chromium.org
        <mailto:blink-dev+unsubscr...@chromium.org>.
        To view this discussion visit
        
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6865f0bc.170a0220.11148a.0380.GAE%40google.com
        
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6865f0bc.170a0220.11148a.0380.GAE%40google.com?utm_medium=email&utm_source=footer>.

-- You received this message because you are subscribed to the Google
    Groups "blink-dev" group.
    To unsubscribe from this group and stop receiving emails from it,
    send an email to blink-dev+unsubscr...@chromium.org
    <mailto:blink-dev+unsubscr...@chromium.org>.
    To view this discussion visit
    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYdtSg3QSrq8s2nj4M4skhd4bdyJQyXzocbBx%3D7xs9Pf6w%40mail.gmail.com
    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYdtSg3QSrq8s2nj4M4skhd4bdyJQyXzocbBx%3D7xs9Pf6w%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/02bfeade-ff2e-4ee6-84d1-0c6d6f1f7758n%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/02bfeade-ff2e-4ee6-84d1-0c6d6f1f7758n%40chromium.org?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ee7dc852-fe15-4841-9e73-07281a757062%40chromium.org.

Reply via email to