LGTM3 On Wed, Oct 8, 2025 at 5:23 PM Philip Jägenstedt <[email protected]> wrote:
> LGTM2 > > Thanks for all of the compat analysis, Frank. My sense is that this change > is very likely safe, not just because it's already in Firefox and Safari, > but also based on the spreadsheet and the kind of behavior we should > expect, which mostly falls back to the methods or some constant. > > On Wed, Oct 8, 2025 at 5:19 PM Alex Russell <[email protected]> > wrote: > >> LGTM1 conditional on a killswitch for the rollout. >> >> On Tuesday, October 7, 2025 at 8:47:40 AM UTC-7 Frank Tang (譚永鋒) wrote: >> >>> On Tue, Oct 7, 2025 at 3:08 AM Philip Jägenstedt <[email protected]> >>> wrote: >>> >>>> Hi Frank, >>>> >>>> Did you find all these GitHub projects code in the wild, or by >>>> searching on GitHub? >>>> >>> >>> I only search all the code I can find on GitHub . I am not sure I cover >>> 100% but should be most of them. >>> >>> In any case, thank you for sending all of them! >>>> >>>> How would you summarize the findings of the httparchive analysis after >>>> the additional 11 sites that you checked? Are there any that would end up >>>> throwing an exception if we remove these getters? >>>> >>>> Best regards, >>>> Philip >>>> >>>> On Tue, Oct 7, 2025 at 6:42 AM 'Frank Tang (譚永鋒)' via blink-dev < >>>> [email protected]> wrote: >>>> >>>>> >>>>> Interesting reply >>>>> >>>>> https://github.com/Extended-Thunder/send-later/pull/763#issuecomment-3368417172 >>>>> >>>>> On Fri, Oct 3, 2025 at 5:11 PM Frank Tang (譚永鋒) <[email protected]> >>>>> wrote: >>>>> >>>>>> https://github.com/ubermanu/components/pull/4 >>>>>> https://github.com/azatgt1996/my-tasks/pull/1 >>>>>> https://github.com/greenscreens-io/webcomponents/pull/1 >>>>>> https://github.com/emontnemery/home-assistant-polymer/pull/525 >>>>>> https://github.com/webcamleif/ha-fusion/pull/1 >>>>>> https://github.com/codewec/ha-fusion-pro/pull/22 >>>>>> https://github.com/Yoeori/bsi-seiling/pull/2 >>>>>> https://github.com/esm7/obsidian-tasks/pull/56 >>>>>> https://github.com/jc-cr/obsidian-tasks/pull/1 >>>>>> https://github.com/marcelocrs1/frontend/pull/1 >>>>>> https://github.com/sourceempire/brawl-desktop-app/pull/144 >>>>>> https://github.com/cshaa/svelte-day-picker/pull/16 >>>>>> https://github.com/moshequ/vueflame/pull/1 >>>>>> https://github.com/primozw/strapi-reservations/pull/3 >>>>>> https://github.com/ManfredHu/manfredHu.github.io/pull/30 >>>>>> https://github.com/emontnemery/home-assistant-polymer/pull/525 >>>>>> https://github.com/bogdanbotezatu/ha-fusion/pull/5 >>>>>> https://github.com/bedrockio/chrono/pull/1 >>>>>> https://github.com/greenscreens-io/webcomponents/pull/1 >>>>>> https://github.com/madsstoumann/browser-style/pull/2 >>>>>> https://github.com/azatgt1996/my-tasks/pull/1 >>>>>> https://github.com/ubermanu/components/pull/4 >>>>>> >>>>>> >>>>>> On Fri, Oct 3, 2025 at 4:39 PM Frank Tang (譚永鋒) <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> also filed >>>>>>> https://github.com/marchbox/intl-elements/issues/64 >>>>>>> >>>>>>> https://github.com/alexzhirkevich/compose-cupertino/pull/95 >>>>>>> https://github.com/Extended-Thunder/send-later/pull/763 >>>>>>> https://github.com/MMRIZE/MMM-CalendarExt3/pull/237 >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, Oct 3, 2025 at 4:26 PM Frank Tang (譚永鋒) <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> >>>>>>>> https://github.com/brettz9/intl-locale-textinfo-polyfill/issues/2#issuecomment-3367441048 >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Oct 2, 2025 at 1:37 PM Frank Tang (譚永鋒) <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> see >>>>>>>>> >>>>>>>>> >>>>>>>>> https://docs.google.com/spreadsheets/d/1detya2rQsAHzZYm13x-zn-Rea97gtqCisX9fRcmFAFg/edit?usp=sharing&resourcekey=0-4FRh3mbBAS2JLKtAtgdzBg >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Oct 2, 2025 at 1:33 PM Frank Tang (譚永鋒) <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> I have similar finding. I look at about 10 more after Philip. >>>>>>>>>> Almost all of them try to access >>>>>>>>>> textInfo and weekInfo only >>>>>>>>>> And about 30% of them fallback to getTextInfo or a default value. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Thu, Aug 28, 2025 at 1:41 AM Philip Jägenstedt < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Checking in on this again, >>>>>>>>>>> https://chromestatus.com/metrics/feature/timeline/popularity/5232 >>>>>>>>>>> shows increasing usage, so it would be good to decide on a path >>>>>>>>>>> forward. >>>>>>>>>>> >>>>>>>>>>> Based on the use counter call sites >>>>>>>>>>> <https://source.chromium.org/chromium/chromium/src/+/main:v8/src/builtins/builtins-intl.cc;l=799-854;drc=50ade2d8d071e10bc5d53234bb2c0b311c515940>, >>>>>>>>>>> these are the properties in question: >>>>>>>>>>> >>>>>>>>>>> - Intl.Locale.prototype.calendars >>>>>>>>>>> - Intl.Locale.prototype.collations >>>>>>>>>>> - Intl.Locale.prototype.hourCycles >>>>>>>>>>> - Intl.Locale.prototype.numberingSystems >>>>>>>>>>> - Intl.Locale.prototype.textInfo >>>>>>>>>>> - Intl.Locale.prototype.timeZones >>>>>>>>>>> - Intl.Locale.prototype.weekInfo >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> I exported the 106 sites listed on chromestatus.com into a >>>>>>>>>>> spreadsheet, sorted them randomly: >>>>>>>>>>> >>>>>>>>>>> https://docs.google.com/spreadsheets/d/1_oOhcPq5fgOkd4pD9crSJqu2fnpyL2j7M9pxw7n_nD8/edit?usp=sharing >>>>>>>>>>> >>>>>>>>>>> I looked at the first 10, searching for "Intl.Locale" in >>>>>>>>>>> devtools. >>>>>>>>>>> >>>>>>>>>>> 8 of them use textInfo without fallback to getTextInfo(). >>>>>>>>>>> Instead, they just assume "ltr". If the sites don't support any RTL >>>>>>>>>>> language, then I don't think anybody would notice, but presumably >>>>>>>>>>> some >>>>>>>>>>> sites like adobe.com do. >>>>>>>>>>> >>>>>>>>>>> 2 of the sites seem to correctly fall back to the get*() >>>>>>>>>>> methods, and if they changed the order of their code wouldn't even >>>>>>>>>>> trigger >>>>>>>>>>> our use counters. >>>>>>>>>>> >>>>>>>>>>> I found and filed a bug for the most common pattern: >>>>>>>>>>> https://github.com/expo/expo/issues/39205 >>>>>>>>>>> >>>>>>>>>>> Frank, would you be able to analyze another 10 or 20 to see if >>>>>>>>>>> there are other common patterns? >>>>>>>>>>> >>>>>>>>>>> From what I've found I'm fairly confident the breakage wouldn't >>>>>>>>>>> be severe, but it would be good to notify libraries that need to >>>>>>>>>>> adjust, so >>>>>>>>>>> that developers have a fix if they are affected. >>>>>>>>>>> >>>>>>>>>>> Best regards, >>>>>>>>>>> Philip >>>>>>>>>>> >>>>>>>>>>> On Thu, Mar 13, 2025 at 4:54 PM Chris Harrelson < >>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Mar 12, 2025 at 4:22 PM 'Panos Astithas' via blink-dev < >>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> On Wed, Mar 12, 2025 at 3:12 PM Mike Taylor < >>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> On 3/12/25 5:38 PM, Frank Tang (譚永鋒) wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Wed, Mar 12, 2025 at 8:19 AM Chris Harrelson < >>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Wed, Mar 5, 2025 at 10:39 AM 'Frank Tang (譚永鋒)' via >>>>>>>>>>>>>>> blink-dev <[email protected]> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Wed, Mar 5, 2025 at 6:02 AM Daniel Bratell < >>>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Looks like the use counter LocaleInfoObsoleteGetters is at >>>>>>>>>>>>>>>>> 0.033% which is a bit high. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Dear Daniel: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> From your point of view, could you please define what >>>>>>>>>>>>>>>> number would be considered as not "high" or "low enough" ? >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> We don't have a hard and fast rule, but in this case it's >>>>>>>>>>>>>>> "high enough" that we would like a bit more info to estimate >>>>>>>>>>>>>>> risk. >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> If there are no hard and fast rules, then how do we determine >>>>>>>>>>>>>> 0.033% is a bit high? but not low enough? gut feeling? >>>>>>>>>>>>>> >>>>>>>>>>>>>> Experience breaking things. See >>>>>>>>>>>>>> https://docs.google.com/document/d/1RC-pBBvsazYfCNNUSkPqAVpSpNJ96U8trhNkfV0v9fk/edit?tab=t.0#heading=h.83o2xr8ayal6. >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I can't see LocaleInfoFunctions at all so does that mean >>>>>>>>>>>>>>>>> that it has never been triggered? >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> No, we didn't hook up that to the same UI. All other intl >>>>>>>>>>>>>>>> features were hook up with this UI and while I added the CL >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> https://chromium-review.googlesource.com/c/chromium/src/+/6020626/ >>>>>>>>>>>>>>>> So >>>>>>>>>>>>>>>> syg@ said I should not use blink_feature but webdx_feature >>>>>>>>>>>>>>>> due to "jstenback's email about WebDX features" >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> So I hooked up the counter of >>>>>>>>>>>>>>>> both kLocaleInfoObsoletedGetters and kLocaleInfoFunctions to >>>>>>>>>>>>>>>> that >>>>>>>>>>>>>>>> but we later on find there are no easy way to access that >>>>>>>>>>>>>>>> info from public UI yet. So in >>>>>>>>>>>>>>>> https://chromium-review.googlesource.com/c/chromium/src/+/6089243 >>>>>>>>>>>>>>>> I change LocaleInfoObsoleteGetters back to blink_feature >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I am not sure how to access the query to check >>>>>>>>>>>>>>>> webdx_feature. If anyone know how to query that, we can see >>>>>>>>>>>>>>>> from that. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Your use counter is here: >>>>>>>>>>>>>>> https://chromestatus.com/metrics/feature/timeline/popularity/5232 >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> That one is for LocaleInfoObsoleteGetters, which is >>>>>>>>>>>>>> blink_feature that we know how to see the counter >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>> Ok, but the URL above also lists various sites that are >>>>>>>>>>>> triggering LocaleInfoObsoleteGetters, ranked by popularity. I'm >>>>>>>>>>>> suggesting >>>>>>>>>>>> checking the top 20 such sites to see if any are broken. >>>>>>>>>>>> >>>>>>>>>>>> [image: Screenshot 2025-03-13 8.53.08 AM.png] >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> What we do not know how to access is kLocaleInfoFunctions, >>>>>>>>>>>>>> which is webdx_feature that we do not know how to access the >>>>>>>>>>>>>> counter. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Please reach out to pastithas@ or kadirtopal@ for help on >>>>>>>>>>>>>> that. >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Unfortunately we don't yet expose these use counters in >>>>>>>>>>>>> ChromeStatus, but we're working on it. In the meantime internal >>>>>>>>>>>>> UMA data >>>>>>>>>>>>> <https://uma.googleplex.com/p/chrome/timeline_v2?sid=f68dc5965348456a1cfb7dae5fa891d8> >>>>>>>>>>>>> should >>>>>>>>>>>>> help make progress here. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Panos >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>>>> Google Groups "blink-dev" group. >>>>>>>>>>>>> To unsubscribe from this group and stop receiving emails from >>>>>>>>>>>>> it, send an email to [email protected]. >>>>>>>>>>>>> To view this discussion visit >>>>>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJ8Nf23YhpqRu91ShWcrQLgeoOrjC5KsDnhexLVK7S-sGM7tfA%40mail.gmail.com >>>>>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJ8Nf23YhpqRu91ShWcrQLgeoOrjC5KsDnhexLVK7S-sGM7tfA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>>>>>>> . >>>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>>> Google Groups "blink-dev" group. >>>>>>>>>>>> To unsubscribe from this group and stop receiving emails from >>>>>>>>>>>> it, send an email to [email protected]. >>>>>>>>>>>> To view this discussion visit >>>>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-Rxs7zGWcNUMv2iDi4GxkWD%3Dh%2B5v8ABuim9z08c7VweQ%40mail.gmail.com >>>>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-Rxs7zGWcNUMv2iDi4GxkWD%3Dh%2B5v8ABuim9z08c7VweQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>>>>>> . >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Frank Yung-Fong Tang >>>>>>>>>> 譚永鋒 / 🌭🍊 >>>>>>>>>> Sr. Software Engineer >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Frank Yung-Fong Tang >>>>>>>>> 譚永鋒 / 🌭🍊 >>>>>>>>> Sr. Software Engineer >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Frank Yung-Fong Tang >>>>>>>> 譚永鋒 / 🌭🍊 >>>>>>>> Sr. Software Engineer >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Frank Yung-Fong Tang >>>>>>> 譚永鋒 / 🌭🍊 >>>>>>> Sr. Software Engineer >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Frank Yung-Fong Tang >>>>>> 譚永鋒 / 🌭🍊 >>>>>> Sr. Software Engineer >>>>>> >>>>> >>>>> >>>>> -- >>>>> Frank Yung-Fong Tang >>>>> 譚永鋒 / 🌭🍊 >>>>> Sr. Software Engineer >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "blink-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion visit >>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CA%2B7fzPGbc8vSq5ajtvi2if_57BZrc0UosN14yfrQ-Y7tc2ZY_Q%40mail.gmail.com >>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CA%2B7fzPGbc8vSq5ajtvi2if_57BZrc0UosN14yfrQ-Y7tc2ZY_Q%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> >>> >>> -- >>> Frank Yung-Fong Tang >>> 譚永鋒 / 🌭🍊 >>> Sr. Software Engineer >>> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYdL2k1%2BqFLPca4v7fsL1JcSLXr54YzS6mTOKBqvSmZbNQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYdL2k1%2BqFLPca4v7fsL1JcSLXr54YzS6mTOKBqvSmZbNQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSJkskQafnGujok%2BCZsQCDNpdVDKCpK5zi5JNuDp2dq94w%40mail.gmail.com.
