LGTM2
On Sat, Dec 6, 2025 at 2:02 AM Philip Jägenstedt <[email protected]> wrote: > LGTM1, thanks for fixing this oversight! > > On Thu, Dec 4, 2025 at 2:44 PM Javier Fernandez <[email protected]> > wrote: > >> *Contact emails* >> [email protected] >> >> *Specification* >> https://drafts.csswg.org/css-animations/#interface-globaleventhandlers >> >> *Design docs* >> *No information provided* >> >> https://developer.mozilla.org/en-US/docs/Web/API/Element/animationcancel_event >> >> *Summary* >> >> The CSS Animations Level 1 extends [1] the GlobalEventsHandler Interface >> defined in the HTML spec [2], declaring 4 new event handlers: >> onanimationstart, onanimationiteration, onanimationend and >> onanimationcancel. Only the 'onanimationcancel' event handler has been >> missing from the GobalEventsHandler IDL. >> [1]https://drafts.csswg.org/css-animations/#interface-globaleventhandlers >> >> [2] >> https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers >> >> *Blink component* >> Blink>Animation >> <https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3EAnimation%22> >> >> *Web Feature ID* >> animations-css <https://webstatus.dev/features/animations-css> >> >> *Motivation* >> The 'onanimationcancel" event handler should be exposed through the >> GlobalEventHandlers interface so that web applications can detect when the >> animation stops running in a way that does not fire an 'animationend' >> event, such as a change in the 'animation-name' that removes the animation, >> or the animating element or one of its ancestors becoming display:none. >> >> *Initial public proposal* >> *No information provided* >> >> *TAG review* >> *No information provided* >> >> *TAG review status* >> Not applicable >> >> *Risks* >> >> >> *Interoperability and Compatibility* >> This change improves interop making Chrome match with the rest of the >> engines, which has been already shipped the feature long time ago. >> >> *Gecko*: Shipped/Shipping ( >> https://searchfox.org/firefox-main/rev/f81fae7890605739dd8dde14755f159fe6beb8aa/dom/webidl/EventHandler.webidl#134 >> ) https://bugzilla.mozilla.org/show_bug.cgi?id=1302648 >> >> *WebKit*: Shipped/Shipping ( >> https://github.com/WebKit/WebKit/blob/0c009bd3041dcffddadd9656a928076ba262462f/Source/WebCore/animation/GlobalEventHandlers%2BCSSAnimations.idl#L31 >> ) >> >> *Web developers*: No signals >> >> *Other signals*: >> >> *WebView application risks* >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> *No information provided* >> >> >> *Debuggability* >> *No information provided* >> >> *Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, ChromeOS, Android, and Android WebView)?* >> No >> >> *Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?* >> Yes >> There is 'css/css-animations/idlharness.html' [1] test to check whether >> the attribute it's properly exposed in the globalEventHandler interface. >> >> [1] >> https://wpt.fyi/results/css/css-animations/idlharness.html?label=master&label=experimental&aligned >> <https://wpt.fyi/results/css/css-animations/idlharness.html?label=master&label=experimental&aligned> >> >> *Flag name on about://flags* >> N/A >> >> *Finch feature name* >> *No information provided* >> >> *Non-finch justification* >> No need for a finch flag given that the 'cancelanimation' event has been >> implemented long ago and this change it's just about exposing it through >> the globalEventsHandlers interface >> >> *Rollout plan* >> Will ship enabled for all users >> >> *Requires code in //chrome?* >> False >> >> *Tracking bug* >> https://issues.chromium.org/issues/464010037 >> >> *Estimated milestones* >> Shipping on desktop 145 >> Shipping on Android 145 >> Shipping on WebView 145 >> >> *Anticipated spec changes* >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> *No information provided* >> >> *Link to entry on the Chrome Platform Status* >> https://chromestatus.com/feature/5160464445210624?gate=6492452351508480 >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/29d87493-0907-4bc6-ba8d-f5dd3ad37438%40igalia.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/29d87493-0907-4bc6-ba8d-f5dd3ad37438%40igalia.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYc9kW-2yXxJ_9Bk%3D53dhG%2B13dAKuyigDBprBFkkk5WXnA%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYc9kW-2yXxJ_9Bk%3D53dhG%2B13dAKuyigDBprBFkkk5WXnA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- TAMURA Kent Software Engineer, Google -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqHXxNQVP%2BgzE%2BSC%3DxZu_zUrV0EbUEy4gfhDU1VBs-ak4w%40mail.gmail.com.
