#195: Attach file form à la GMail --------------------------+---------------------- Reporter: jdreimann | Owner: olemis Type: enhancement | Status: accepted Priority: major | Milestone: Component: ui design | Version: Resolution: | Keywords: --------------------------+----------------------
Comment (by gjm): Replying to [comment:7 jdreimann]: > Replying to [comment:6 olemis]: > > Feedback is welcome . > > Thanks Olemis, looking good! > I would remove some of the buttons though: > 1. **Start upload** - I believe dragging a file onto the page or selecting it in the file dialogue is enough of an indication that the user wants to upload it. > 1. **Cancel upload** - This should be done individually via the {{{ x Cancel }}} action you've already placed next to the upload indicator. > 1. **Clear failures** - Again, this should be done individually. Failures matter, especially in these low volume transactions (usually someone will attach one or two files only); not the situation in which I would expect batch clearing to be helpful. > 1. **Toggle all** - I assume this is related to the previous three buttons? > > Just to clarify: in the description field, what does the button at the end do? I can't quite make it out from the screenshot. In the mockup it was meant to confirm the input to save it, or cancel to clear the changes to them based on the inline editing discussions on the mailing list recently. Note: I think that we should discuss this on bh-dev so I will reply to the subsequent email that this comment creates for us to continue there. Actually, olemis has a point. I didn't spot that issue as I did not understand that jdriemann wanted the downloads to start at the earliest opportunity. My concern here is that sometimes people are going to find that they are uploading files that they did not mean to. I realise that jdreimann's suggested drop area reduces the likelihood that a file will be dropped accidentally when the drag action was meant for another location, but mistakes will still happen just from selecting the wrong file. I would suggest that making sure it is possible to confirm all with a single button click would be enough to reduce inconvenience here - and I am not suggesting we should have an additional "are you sure" after that. Finally, even if my reasoning above is a bit too protectionist, immediate upload certainly seems to me to be inconsistent with the conclusions I believe we have come to about inline editing on the same page. -- Ticket URL: <https://issues.apache.org/bloodhound/ticket/195#comment:8> Apache Bloodhound <https://issues.apache.org/bloodhound/> The Apache Bloodhound (incubating) issue tracker