#293: footer whitelabelling results in footer specifying different apache projects ------------------------+--------------------------- Reporter: gjm | Owner: gjm Type: defect | Status: needinfo(new) Priority: critical | Milestone: Release 4 Component: dashboard | Version: Resolution: | Keywords: ------------------------+---------------------------
Comment (by gjm): Replying to [comment:3 peter]: > 1. Just checking: This is how it has been before whitelabeling efforts or am I missing something? Before whitelabelling, we didn't need to consider the consistency of branding when the name gets changed. > 2. What does this ticket suggest? That the "Apache TM" also comes from trac.ini? Is ApacheTM mandatory in footer? Is whilelabeler allowed to remove or change it? Should only the link be removed? This ticket only suggests that when somebody decides to make use of the whitelabelling to change the name to mylabel, they probably wouldn't expect to be calling themselves {{{ #!html <p>Apache<sup>TM</sup> mylabel</p> }}} If this is not just a facility for us to rename our own project, it would seem that this needs to be a bit more configurable. One relatively simple solution for this ticket would just to use {{{application_full}}}. Perhaps this is best for the moment. I expect that would probably be acceptable enough for the moment. For longer term, we might want to consider something like {{{ #!ini [labels] application_prefix = Apache application_prefix_link = http://www.apache.org/ application_short = Bloodhound }}} such that we can say something like {{{ #!xml <div class="span8" py:with="labels=chrome.labels"> ${labels.footer_left_prefix} Powered by <a href="${labels.application_prefix_link}">${labels.application_prefix}</a> <a href="${href.about()}">${labels.application_short} ${labels.application_version}</a> ${labels.footer_left_postfix} </div> }}} With so much configurability we may also want {{{ #!python application_full = ' '.join((application_prefix, application_short)) }}} though perhaps only when {{{application_full}}} is not specified if there is a good reason to keep it. -- Ticket URL: <https://issues.apache.org/bloodhound/ticket/293#comment:4> Apache Bloodhound <https://issues.apache.org/bloodhound/> The Apache Bloodhound (incubating) issue tracker