Hi there, Until further discussion takes place, and it get to be finally decided if creating the new bloodhound_core directory, I have submitted two new revisions 9e3ae4c , d391096 to my branches moving ModelBase to model.py as accurately observed by rjollos.
Best regards, Franco. 2012/12/7, Apache Bloodhound <[email protected]>: > #280: Move multiproduct.model.ModelBase to dashboard plugin > ---------------------------+------------------------------------ > Reporter: olemis | Owner: franco > Type: enhancement | Status: accepted > Priority: trivial | Milestone: > Component: multiproduct | Version: > Resolution: | Keywords: database model testing > ---------------------------+------------------------------------ > > Comment (by olemis): > > Replying to [comment:5 rjollos]: > > I haven't seen the previous discussion in which it was decided to move > common components to dashboard, > > There's no such record since that was one of the first decisions we made > about Bloodhound . I'm not even sure we had neither mailing lists setup > nor even project page at the time . > > > but my initial impression is that it doesn't make much more sense to > have them in dashboard than in multiproduct. > > I had a brief discussion about this with gjm this evening, and we both > think it might make sense to move the components to a new > `bloodhound_core` directory. > > At the time there was no much time to create and manage a new > bloohound_core directory that noone knew what'd happen with it in the > future . After considering both options we decided that shared assets > would be placed in dashboard because all other plugins already depended > upon it (for widgets). > > > I also think that `ModelBase.py` should be in `model.py` rather than > `db.py`. My understanding is that only the schema and environment upgrade > hooks should be in `db.py`. > > > > +1 > > > I've committed the fixes for the test cases in r1418224. Thank you > franco and olemis! > > A big thank you for taking the the time to review and commit . > :) > > -- > Ticket URL: <https://issues.apache.org/bloodhound/ticket/280#comment:6> > Apache Bloodhound <https://issues.apache.org/bloodhound/> > The Apache Bloodhound (incubating) issue tracker >
