[ 
https://issues.apache.org/jira/browse/BLUR-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573095#comment-13573095
 ] 

Aaron McCurry commented on BLUR-56:
-----------------------------------

I like the remove it suggestion.  However maybe should somehow merge the 2 
classes together and make it easier to use.
                
> Change BlurClient so that getClient() has consistent expectations
> -----------------------------------------------------------------
>
>                 Key: BLUR-56
>                 URL: https://issues.apache.org/jira/browse/BLUR-56
>             Project: Apache Blur
>          Issue Type: Improvement
>            Reporter: Tim Williams
>            Priority: Minor
>
> With BlurClient.getClient(List<Connection> conns), it is expected (and 
> encouraged) that you can call it before each and every search.  There's a 
> sister call, BlurClient.getClient(String conn), where there is a parsing 
> penalty to calling it each and every time, we should do one of a) document 
> the behavior b) remove the later, or c) change the string impl so that it 
> doesn't reparse.  Personally, i'd rather remove that one and just encourage 
> users to go to the BlurClientManager to get a list of conns from a string 
> before calling BlurClient.getClient().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to