[
https://issues.apache.org/jira/browse/BLUR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630999#comment-13630999
]
Gagan Deep Juneja edited comment on BLUR-67 at 4/13/13 9:40 AM:
----------------------------------------------------------------
I agree with your point that javascript function in property file looks ugly
and We may go ahead with the approach you described above. But here if we go
with parent class BlurMetricsReporter then user should be aware of all the
Reporter classes that Blur supports. What you say on this?
Here I have attached one class for Ganglia Reporter named
GangliaBlurMetricsReporter. I defined many properties for Ganglia reporter
based on the constructors of Ganglia but only host name and port are sufficient
to start Ganglia reporter, for rest of the properties we can pass default
values.
We can write classed on the same line for following list of reportes.
1. JMX
2. Console
3. CSV
4. SLF4J
5. GangliaReporter
6. GraphiteReporter
And on top of these classes we will have one util class which based on the
reporters (comma separated classes in property file) list enable the respective
Reporters.
Please let me know your feedback so that we can move ahead and close this asap.
was (Author: gagan):
I agree with your point that javascript function in property file looks
ugly and We may go ahead with the approach you described above. But here if we
go with parent class BlurMetricsReporter then user should be aware of all the
Reporter classes that Blur supports. What you say on this?
Here I have created one class for Ganglia Reporter named
GangliaBlurMetricsReporter. I defined many properties for Ganglia reporter
based on the constructors of Ganglia but only host name and port are sufficient
to start Ganglia reporter, for rest of the properties we can pass default
values.
We can write classed on the same line for following list of reportes.
1. JMX
2. Console
3. CSV
4. SLF4J
5. GangliaReporter
6. GraphiteReporter
And on top of these classes we will have one util class which based on the
reporters (comma separated classes in property file) list enable the respective
Reporters.
Please let me know your feedback so that we can move ahead and close this asap.
> Add config options for metrics reporters
> ----------------------------------------
>
> Key: BLUR-67
> URL: https://issues.apache.org/jira/browse/BLUR-67
> Project: Apache Blur
> Issue Type: Bug
> Affects Versions: 0.1.5
> Reporter: Aaron McCurry
> Fix For: 0.1.5
>
> Attachments: GangliaBlurMetricsReporter.java
>
>
> The default metrics reporter is JMX per JVM. However there is no way for the
> metrics to be configured with another reporter such as ganglia.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
