thanks for committing this, anyway I'm still seeing some differences from this
project
https://github.com/rodrigods/xidletime/blob/master/xprintidle.c
I see you don't check error return codes (the value is unitializaed?
unpredicible behaviour?)
idle_time is set to 0, so what does happen if you divide it by 1000?
and on the first run you take the else branch, because disp is NULL
1951 } else {
1952 disp = XOpenDisplay(NULL);
1953 // XOpenDisplay may return NULL if there is no running X
1954 // or DISPLAY points to wrong/invalid display
1955 //
1956 if (disp != NULL) {
1957 int event_base_return, error_base_return;
1958 xssInfo = XScreenSaverAllocInfo();
1959 if (!XScreenSaverQueryExtension(
1960 disp, &event_base_return, &error_base_return
1961 )){
1962 // how to handle failure?
1963 }
1964 }
I don't see any idle_time in this branch, moreover I don't see any
XScreenSaverQueryInfo
call (I don't even know if it is needed or not)
Do you think the code is already right or can we have a code more close to the
reference one?
(Disclaimer, I don't know what does this code, I'm not a XSS/DPMS expert)
Best regards and thanks for applying the patch!
Gianfranco
Il Lunedì 3 Febbraio 2014 21:48, David Anderson <[email protected]> ha
scritto:
Thanks!
>I committed this.
>-- David
>
>
>On 03-Feb-2014 10:10 AM, Gianfranco Costamagna wrote:
>> Hi Boinc developers, we (I think) have finally managed how to properly
>> detect idle detection
>>
>> the patch is available here [1], fixing this ubuntu bug [2]
>>
>>
>>
>> [1]
>> http://anonscm.debian.org/gitweb/?p=pkg-boinc/boinc.git;a=commitdiff;h=ea24b74d14371df8d15440daf6968c77af76f6e9
>> [2] https://bugs.launchpad.net/ubuntu/+source/boinc/+bug/1274456
>> can anybody please commit it?
>>
>>
>> Gianfranco
>>
>> _______________________________________________
>> boinc_alpha mailing list
>> [email protected]
>> http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_alpha
>> To unsubscribe, visit the above URL and
>> (near bottom of page) enter your email address.
>>
>
>
>
_______________________________________________
boinc_dev mailing list
[email protected]
http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev
To unsubscribe, visit the above URL and
(near bottom of page) enter your email address.
