Oops!  Fixed; thanks!

This is a warning that not all compilers might flag;
printf("foo")
is technically valid but not generally what you want.

-- D

On 5/12/2017 2:20 AM, Gianfranco Costamagna wrote:
Hello David,

boinc_client-app.o `test -f 'app.cpp' || echo './'`app.cpp
/usr/bin/g++ -DHAVE_CONFIG_H -I. -I..  -I.. -I../api -I../db -I../lib -I../lib/mac 
-I../sched -I../tools -I../vda -pthread -Wdate-time -D_FORTIFY_SOURCE=2  -Wall -Wextra 
-Wshadow -Wredundant-decls -Wdisabled-optimization -Wpointer-arith -Wstrict-aliasing 
-Wcast-align  -I/usr/include -I/usr/include/openssl  -g -O3 
-fdebug-prefix-map=/<<BUILDDIR>>/boinc-7.7.0+dfsg~git20170511+r23716~r6~ubuntu16.10.1=.
 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -O3 -funroll-loops 
-fforce-addr -ffast-math -flto -Wall -c -o boinc_client-app_config.o `test -f 
'app_config.cpp' || echo './'`app_config.cpp
app_config.cpp: In function ‘void 
print_msgs(std::vector<std::__cxx11::basic_string<char> >, PROJECT*)’:
app_config.cpp:128:58: error: format not a string literal and no format 
arguments [-Werror=format-security]
msg_printf_notice(p, false, NULL, msgs[i].c_str());
^
cc1plus: some warnings being treated as errors


+static void print_msgs(vector<string> msgs, PROJECT* p) {
+    for (unsigned int i=0; i<msgs.size(); i++) {
+        msg_printf_notice(p, false, NULL, msgs[i].c_str());
+    }

you probably need to use
msg_printf_notice(p, false, NULL, "%s", msgs[i].c_str());

(note: I didn't test the above)

cheers,

G.

_______________________________________________
boinc_dev mailing list
boinc_dev@ssl.berkeley.edu
https://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev
To unsubscribe, visit the above URL and
(near bottom of page) enter your email address.

Reply via email to