On Tue, Oct 28, 2008 at 5:44 AM, alinome.net <[EMAIL PROTECTED]> wrote: > > Line 637 of barn/scripts/library.php is: > > if ($msg != '') $BOLTmsgOut = "<div class=message>$msg</div><br />"; > > I suggest this: > > if ($msg != '') $BOLTmsgOut = "<div class='message'>$msg</div>"; > > The parameter quotes are mandatory in XHTML. The <br /> is not a bug > but it isn't needed because any block or inline layout should be > achieved with CSS, not hardcoded; that's what the class "message" is > for. > > I'm still working on my local server so I don't validate the pages > yet. When I will validate them, I will probably find more missing > quotes and those little things that cause validation errors.
I added the quotes, but I wasn't 100% convinced about the <br /> at first. After tinkering some, I concluded adding margin-bottom: 7px; is about the equivalent of a line return, so I'll add it to the code and core stylesheet, and hope it don't cause problems. It will of course effect all existing sites. There are some other places in the code we should really think about line returns (as you know) to be really consistent everywhere. It will cause some minor problems with existing sites, but nothing major, and it will probably improve some things. Maybe a few small steps at a time... Thanks again for your attention to detail. With the rapid development BoltWire went through it feels really good to be in a polishing mode! Cheers, Dan --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "BoltWire" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/boltwire?hl=en -~----------~----~----~----~------~----~------~--~---
