On Fri, 5 Mar 2010 23:03:46 -0700, [email protected] wrote: > ok. > here is a better version. i've added back the object so that we can > eventually make the locking smarter.
I quite like the look of some of this. I wish in a way the location stuff could be done automatically by macro or something, but then, that's probably trying to be too clever for now. I promise when I get back I'll have a go at re-doing the store design doc - we have some diagrams and things in SVN, but they're probably a bit out of date. I only have two questions, based on a short glance at the patch (I looked harder at the first one when we talked the other day): 1. is the lock type really needed for unlocking? If so, what happens when you get it wrong? 2. is it possible to promote locks from read-only to read-write? I'm not sure if that was part of the original design or not, but I don't think the API prevents it. I also think in general we should try to think about ways in which we can detect the locking stuff "going wrong" - deadlock detection, that kind of thing - at least for some kind of debugging mode. Cogitating further, the test suite idea is definitely something we should try to do, particularly in the store I think. This is all meat for further discussion though; I quite like the patch you posted :) Ta Alex (waiting in a computer room for his better half to finish Facebooking...) _______________________________________________ Bongo-devel mailing list [email protected] https://mail.gna.org/listinfo/bongo-devel
