Daniel Brockman <[EMAIL PROTECTED]> writes:
> Anyway, please consider the following patch. I believe it
> is fit for installation, but you may want to make changes.
Good work! I have only commented on a few details below.
> + (cond ((or stream-name stream-genre stream-part-title)
> + `((artist . unknown)
> + (album . unknown)
> + (stream (uri . ,file-name)
> + (uri-title . ,uri-title)
> + (name . ,stream-name)
> + (genre . ,stream-genre)
> + (part-title . ,stream-part-title))))
> + (uri-title
> + `((artist . unknown)
> + (album . unknown)
> + (track (title . ,(or uri-title stream-name)))))
> + (t
> + (bongo-infoset-from-file-name file-name)))))
In `bongo-uri-track-infoset'. The stream-name property is nil in the
uri-title clause, so you can remove it. Or maybe, in case something
else was intended, this should be reworked?
> + (when (or stream-name stream-genre stream-part-title)
> + (bongo-stream-metadata-changed player)))))
In the VLC backend, it should be `bongo-player-metadata-changed' here.
> (with-bongo-buffer
> - (apply 'bongo-insert-line 'bongo-file-name uri
> - (when title
> - (list 'bongo-infoset `((artist . unknown)
> - (album . unknown)
> - (track (title . ,title)))))))
> + (bongo-insert-line 'bongo-file-name uri))
In `bongo-insert-uri', this ignores the user title completely. I think
it's supposed to be
(apply 'bongo-insert-line 'bongo-file-name uri
(when title
(list 'bongo-uri-title
(and (not (equal title "")) title))))
That's all.
_______________________________________________
bongo-devel mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/bongo-devel
