----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2446/#review2905 -----------------------------------------------------------
Ship it! it is OK. +1. thanks Ivan. - Sijie On 2011-10-28 10:34:15, Ivan Kelly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2446/ > ----------------------------------------------------------- > > (Updated 2011-10-28 10:34:15) > > > Review request for bookkeeper. > > > Summary > ------- > > The path to the protobuf spec is wrong in lib/Makefile.am. > > I also cleaned up the tests, and made it use the provided scripts to stop and > start bookkeeper and hedwig daemons. > > > This addresses bug BOOKKEEPER-71. > https://issues.apache.org/jira/browse/BOOKKEEPER-71 > > > Diffs > ----- > > hedwig-client/src/main/cpp/README PRE-CREATION > hedwig-client/src/main/cpp/config.h.in 19266b3 > hedwig-client/src/main/cpp/configure.ac 6903cc5 > hedwig-client/src/main/cpp/inc/hedwig/callback.h c975e88 > hedwig-client/src/main/cpp/inc/hedwig/client.h b540fe0 > hedwig-client/src/main/cpp/lib/Makefile.am 9a53138 > hedwig-client/src/main/cpp/lib/channel.h ea78054 > hedwig-client/src/main/cpp/lib/channel.cpp 8e9397a > hedwig-client/src/main/cpp/lib/client.cpp 2900cff > hedwig-client/src/main/cpp/lib/clientimpl.h 22451b0 > hedwig-client/src/main/cpp/lib/clientimpl.cpp 67198de > hedwig-client/src/main/cpp/lib/data.h 3d5fe5f > hedwig-client/src/main/cpp/lib/data.cpp 34a3125 > hedwig-client/src/main/cpp/lib/eventdispatcher.cpp 47a87bd > hedwig-client/src/main/cpp/lib/exceptions.cpp b46178a > hedwig-client/src/main/cpp/lib/publisherimpl.cpp 2573664 > hedwig-client/src/main/cpp/lib/subscriberimpl.h 1412940 > hedwig-client/src/main/cpp/lib/subscriberimpl.cpp 2521931 > hedwig-client/src/main/cpp/lib/util.h 79137e8 > hedwig-client/src/main/cpp/lib/util.cpp 0ae5a3e > hedwig-client/src/main/cpp/scripts/network-delays.sh f566098 > hedwig-client/src/main/cpp/scripts/server-control.sh fa7f1c1 > hedwig-client/src/main/cpp/scripts/tester.sh c288076 > hedwig-client/src/main/cpp/test/Makefile.am 84db87f > hedwig-client/src/main/cpp/test/main.cpp ef9190e > hedwig-client/src/main/cpp/test/publishtest.cpp 95599d7 > hedwig-client/src/main/cpp/test/pubsubdatatest.cpp bb7484b > hedwig-client/src/main/cpp/test/pubsubtest.cpp c0feade > hedwig-client/src/main/cpp/test/servercontrol.h cac09e6 > hedwig-client/src/main/cpp/test/servercontrol.cpp 49696b7 > hedwig-client/src/main/cpp/test/subscribetest.cpp 41da339 > hedwig-client/src/main/cpp/test/util.h 2d92244 > hedwig-client/src/main/cpp/test/utiltest.cpp 99ef5f3 > hedwig-server/src/test/java/org/apache/hedwig/ServerControl.java be64f93 > hedwig-server/src/test/java/org/apache/hedwig/ServerControlDaemon.java > 14de705 > > Diff: https://reviews.apache.org/r/2446/diff > > > Testing > ------- > > > Thanks, > > Ivan > >
