[
https://issues.apache.org/jira/browse/BOOKKEEPER-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138223#comment-13138223
]
[email protected] commented on BOOKKEEPER-71:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2446/#review2905
-----------------------------------------------------------
Ship it!
it is OK. +1.
thanks Ivan.
- Sijie
On 2011-10-28 10:34:15, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2446/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-28 10:34:15)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The path to the protobuf spec is wrong in lib/Makefile.am.
bq.
bq. I also cleaned up the tests, and made it use the provided scripts to stop
and start bookkeeper and hedwig daemons.
bq.
bq.
bq. This addresses bug BOOKKEEPER-71.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-71
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. hedwig-client/src/main/cpp/README PRE-CREATION
bq. hedwig-client/src/main/cpp/config.h.in 19266b3
bq. hedwig-client/src/main/cpp/configure.ac 6903cc5
bq. hedwig-client/src/main/cpp/inc/hedwig/callback.h c975e88
bq. hedwig-client/src/main/cpp/inc/hedwig/client.h b540fe0
bq. hedwig-client/src/main/cpp/lib/Makefile.am 9a53138
bq. hedwig-client/src/main/cpp/lib/channel.h ea78054
bq. hedwig-client/src/main/cpp/lib/channel.cpp 8e9397a
bq. hedwig-client/src/main/cpp/lib/client.cpp 2900cff
bq. hedwig-client/src/main/cpp/lib/clientimpl.h 22451b0
bq. hedwig-client/src/main/cpp/lib/clientimpl.cpp 67198de
bq. hedwig-client/src/main/cpp/lib/data.h 3d5fe5f
bq. hedwig-client/src/main/cpp/lib/data.cpp 34a3125
bq. hedwig-client/src/main/cpp/lib/eventdispatcher.cpp 47a87bd
bq. hedwig-client/src/main/cpp/lib/exceptions.cpp b46178a
bq. hedwig-client/src/main/cpp/lib/publisherimpl.cpp 2573664
bq. hedwig-client/src/main/cpp/lib/subscriberimpl.h 1412940
bq. hedwig-client/src/main/cpp/lib/subscriberimpl.cpp 2521931
bq. hedwig-client/src/main/cpp/lib/util.h 79137e8
bq. hedwig-client/src/main/cpp/lib/util.cpp 0ae5a3e
bq. hedwig-client/src/main/cpp/scripts/network-delays.sh f566098
bq. hedwig-client/src/main/cpp/scripts/server-control.sh fa7f1c1
bq. hedwig-client/src/main/cpp/scripts/tester.sh c288076
bq. hedwig-client/src/main/cpp/test/Makefile.am 84db87f
bq. hedwig-client/src/main/cpp/test/main.cpp ef9190e
bq. hedwig-client/src/main/cpp/test/publishtest.cpp 95599d7
bq. hedwig-client/src/main/cpp/test/pubsubdatatest.cpp bb7484b
bq. hedwig-client/src/main/cpp/test/pubsubtest.cpp c0feade
bq. hedwig-client/src/main/cpp/test/servercontrol.h cac09e6
bq. hedwig-client/src/main/cpp/test/servercontrol.cpp 49696b7
bq. hedwig-client/src/main/cpp/test/subscribetest.cpp 41da339
bq. hedwig-client/src/main/cpp/test/util.h 2d92244
bq. hedwig-client/src/main/cpp/test/utiltest.cpp 99ef5f3
bq. hedwig-server/src/test/java/org/apache/hedwig/ServerControl.java be64f93
bq. hedwig-server/src/test/java/org/apache/hedwig/ServerControlDaemon.java
14de705
bq.
bq. Diff: https://reviews.apache.org/r/2446/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> hedwig c++ client does not build.
> ----------------------------------
>
> Key: BOOKKEEPER-71
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-71
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-71.diff, BOOKKEEPER-71.diff,
> BOOKKEEPER-71.diff, BOOKKEEPER-71.diff
>
>
> The path to the protobuf spec is wrong in lib/Makefile.am.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
