[
https://issues.apache.org/jira/browse/BOOKKEEPER-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170838#comment-13170838
]
Ivan Kelly commented on BOOKKEEPER-133:
---------------------------------------
Could you put this in review board, as it's quite a large patch. A few comments
from what I've seen so far.
a) PersistenceManager#stop seems to be a noop in all cases. Remove it for the
moment.
b) ZkTopicManager#unregisterWithZookeeper shouldn't be needed. An EPHEMERAL
znode is deleted when the session goes away (after zookeeper timeout). Is this
too late for your requirement?
How is the lazy cleanup causing problems?
Also, I don't understand what the consume message is for? It is to clear the
outstanding messages for the subscription?
> Hub server should update subscription state to zookeeper when losing topic or
> shutting down
> -------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-133
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-133
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-133.patch
>
>
> Currently hub server use counter-based mechanism to update subscription state
> lazily to zookeeper.
> But in the following case, it didn't do it.
> 1) losing ownership of Topic
> 2) hub server shuts down
> 3) a subscription channel disconnected
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
