[
https://issues.apache.org/jira/browse/BOOKKEEPER-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199057#comment-13199057
]
[email protected] commented on BOOKKEEPER-152:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3737/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
Proposed fix ensures that at least one of each quorum replies to
ReadLastConfirmed.
Refactors code a bit to make the read last confirmed common for recovery and
standalone read last confirmed.
The bug here was actually that we were waiting for quorumSize responses, from
the bookies, when really all we need to get a response from one bookie in each
possible quorum. in the 2/2 case as above this means only 1 bookie need
response.
There's a fix for the timeouts and an improvement in fencing which fixing this
uncovered.
This addresses bug BOOKKEEPER-152.
https://issues.apache.org/jira/browse/BOOKKEEPER-152
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DistributionSchedule.java
f2ed6bd
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
547e240
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
4625bbb
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
43e999d
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RoundRobinDistributionSchedule.java
4a88747
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
ded1379
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java
8526db5
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java
db1a763
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java
5873255
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerRecoveryTest.java
77a2f69
Diff: https://reviews.apache.org/r/3737/diff
Testing
-------
Thanks,
Ivan
> Can't recover a ledger whose current ensemble contain failed bookie.
> --------------------------------------------------------------------
>
> Key: BOOKKEEPER-152
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-152
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BK-152.draft.patch, BOOKKEEPER-152.diff
>
>
> Suppose we have a unclosed ledger L, whose ensemble size is 2, quorum size is
> 2. the ledger's current ensemble is <bk1, bk2>.
> bk2 is crashed.
> we use recovery tool to recover entries in bk2. $
> bookkeeper-server/bin/bookkeeper org.apache.bookkeeper.tools.BookKeeperTools
> bk2
> recovery failed due to recovery tool can't open ledger L, since ledger L
> doesn't have enough quorum to readLastConfirmed entry.
> (asyncOpenLedgerNoRecovery)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
