[
https://issues.apache.org/jira/browse/BOOKKEEPER-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400394#comment-13400394
]
Ivan Kelly commented on BOOKKEEPER-304:
---------------------------------------
This patch is very good. I have a couple of comments/questions.
# putLedger should be synchronized.
# import StringUtils rather than using the fully qualified name.
# In case of error, throw an exception from #getBookieToLedgerIndex. at the
auditor level, this should result in the auditor giving up control. When a new
auditor takes over, it should run a check between the contents of the
bookie->ledger map and the current available bookies.
# It should throw a custom exception, not IOException. I've created a
ReplicationException class in BOOKKEEPER-246. Perhaps you add one under that,
or use the UnavailableException already defined there.
# Perhaps, instead of storing the ledgers as a List<Long>, store them as a
HashSet<Long>. Storing as a list, will make putLedger very slow if there is a
lot of ledgers (List#contains is O(n)).
#Why do you need the grace period in testEnsembleReformation()?
> Prepare bookie vs ledgers cache and will be used by the Auditor
> ---------------------------------------------------------------
>
> Key: BOOKKEEPER-304
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-304
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-304.1.patch, BOOKKEEPER-304.2.patch
>
>
> This JIRA discusses how to build bookie -> ledgers cache and this will be
> used by the Auditor to publish the suspected ledgers of failed bookies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
