[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422019#comment-13422019
 ] 

Sijie Guo commented on BOOKKEEPER-349:
--------------------------------------

although I don't have windows environment to run it to verify it, the changes 
are necessary and right to me. +1.
                
> Entry logger should close all the chennels which are there in Map, instead of 
> closing only current channel.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-349
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-349
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 4.1.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: BOOKKEEPER-349.patch
>
>
> I have seen this on restarting the same bookies from same JVM( in one of mey 
> testcase which I was writing for autoRecovery work), i.e, all channels are 
> not getting closed.
> When we restart the same bookie, there are 0.log channel will be a older 
> channel. Since the current code cares about only current logChannel. So, we 
> are not releasing the older channels on EntryLogger shutdown. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to