[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423916#comment-13423916
 ] 

Flavio Junqueira commented on BOOKKEEPER-352:
---------------------------------------------

Branch 4.1 commit. CommitCommitted revision 1366409.
                
> Should not use static ServerStats/BKStats instance in 
> TestServerStats/TestBKStats
> ---------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-352
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-352
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 4.2.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0, 4.1.1
>
>         Attachments: BOOKKEEPER-352.diff
>
>
> TestServers failed when running whole test. Because TestServers uses 
> ServerStats instance directly. ServerStats is a static instance, which will 
> be used across whole testing. so the numSuccessOps would not be zero, the 
> assertion would fail.
> Same problem occurs in TestBKStats. TestBKStats doesn't fail because 
> statistics is turned off by default. The value happened to be zero. But it 
> still is not a good idea to use static instance during testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to