[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424896#comment-13424896
]
Sijie Guo commented on BOOKKEEPER-311:
--------------------------------------
{quote}
IMO, we have to be very strict towards the conventions for the long term
maintenance(neatly) of the code. Otherwise, code will become too ugly with the
different conventions placed.
{quote}
agreed. +1.
{quote}
Recently, Hbase also revisited for this point and made their convention to
100+, I remember.
{quote}
yes. 100 is a better wide to control the format, because we had lots of
callbacks written in both BOOKKEEPER and Hedwig.
> Changes in hedwig client api to support JMS spec
> ------------------------------------------------
>
> Key: BOOKKEEPER-311
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-311
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Mridul Muralidharan
> Assignee: Mridul Muralidharan
> Attachments: hedwig-client-consume.patch.1,
> hedwig-client-publish.patch.1, hedwig-client.patch, hedwig-client.patch.3,
> hedwig-client.patch.4, hedwig-client.patch.5
>
>
> Primary changes are :
> a) Add support for returning seq-id for a publish request. This is an api
> change (backwardly compatible for users).
> b) Make consume a sync consume, with addition of an asyncConsume - this is to
> ensure that invoking consume() ensure request makes to server before
> returning (with what reasonable gaurantees that netty allows).
> c) Ensure that explicit close'ing of session will flush buffered consume
> seq-id's when auto-ack is enabled (default in hedwig java client).
> In addition, there are also fixes for
> d) Fix NPE's observed as part of testing JMS provider.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
