> On Aug. 23, 2012, 12:50 p.m., Sijie Guo wrote: > > the new patch looks good to me. only 1 small comment about the exception > > caught. please check as below.
Thanks for pointing that out. I've updated the patch with some other minor changes. > On Aug. 23, 2012, 12:50 p.m., Sijie Guo wrote: > > hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java, > > line 620 > > <https://reviews.apache.org/r/6734/diff/1/?file=143951#file143951line620> > > > > why not catch NoResponseHandlerException? Fixed. - Aniruddha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6734/#review10684 ----------------------------------------------------------- On Aug. 24, 2012, 12:05 a.m., Aniruddha Laud wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6734/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2012, 12:05 a.m.) > > > Review request for bookkeeper, Ivan Kelly and Sijie Guo. > > > Description > ------- > > https://issues.apache.org/jira/browse/BOOKKEEPER-371 > > > Diffs > ----- > > > hedwig-client/src/main/java/org/apache/hedwig/client/exceptions/NoResponseHandlerException.java > PRE-CREATION > > hedwig-client/src/main/java/org/apache/hedwig/client/handlers/MessageConsumeCallback.java > 0d3a1ff > > hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java > 211e1bf > > hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClientImpl.java > a111c8e > > hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java > efba3fb > > hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java > e4eca0d > > hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java > b644e11 > > Diff: https://reviews.apache.org/r/6734/diff/ > > > Testing > ------- > > mvn clean && mvn test passes > > > Thanks, > > Aniruddha Laud > >
