[
https://issues.apache.org/jira/browse/BOOKKEEPER-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-384:
--------------------------------
Attachment: BOOKKEEPER-384.patch
Attached patch addressing 1st and the 2nd
[comments|https://issues.apache.org/jira/browse/BOOKKEEPER-304?focusedCommentId=13442424&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13442424]
bq.1) LedgerManagerFactory and LedgerManager is construct in the tests but they
aren't be closed or uninitialized. it might be not a good practice.
bq.2) It might be better to put them in a for-loop for same code.
> Clean up LedgerManagerFactory and LedgerManager usage in tests
> --------------------------------------------------------------
>
> Key: BOOKKEEPER-384
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-384
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.2.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Priority: Minor
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-384.patch
>
>
> This JIRA to address the [review
> comments|https://issues.apache.org/jira/browse/BOOKKEEPER-304?focusedCommentId=13442424&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13442424]
> in BOOKKEEPER-304
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
