[ https://issues.apache.org/jira/browse/BOOKKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453914#comment-13453914 ]
Sijie Guo commented on BOOKKEEPER-402: -------------------------------------- I think the jira is similar to BOOKKEEPER-75. I had a fix to close subscription channels when lostTopic, which is as part of BOOKKEEPER-252 (it also about closing subscription channels). The easy way is to call deliveryManager#stopServing in subscription manager in ReleaseTopic. since it has the subscription list for a topic, we don't need to maintain another mapping in SubHandler as you proposed in your patch. If BOOKKEEPER-252 is ready to be in recently, I think we don't need to fix it again here. BTW, when you sent a review request, it would be better to attach the patch here too and change the status of the jira to patch available. :-) > Hedwig hub should close subscription channels on losing a topic > --------------------------------------------------------------- > > Key: BOOKKEEPER-402 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-402 > Project: Bookkeeper > Issue Type: Bug > Components: hedwig-server > Reporter: Aniruddha > > If a hub were to lose a topic, it doesn't stop delivery for that topic and > keeps the subscription channels open. It should actively close it and stop > delivery for all subscribers for that topic connected to it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira