[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503797#comment-13503797
 ] 

Ivan Kelly commented on BOOKKEEPER-478:
---------------------------------------

Yes, ZK is pulled in through hadoop-common, so it's fine to remove it from the 
shaded jar. We should go through all the pulled in dependencies to check for 
cases like this. In any case, this is a HDFS jira really, as the pom.xml in 
question is there. We don't need to do anything on the bookkeeper side, but we 
will on the hdfs side once 4.2.0 is released. We'll also need to make changes 
to take advantage of BOOKKEEPER-208.
                
> Changes from BOOKKEEPER-203 broken capability of including bookkeeper-server 
> jar in hidden package of BKJM
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-478
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-478
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Vinay
>             Fix For: 4.2.0
>
>
> BOOKKEEPER-203 introduced changes to LedgerLayout to include 
> ManagerFactoryClass instead of ManagerFactoryName.
> So because of this, BKJM cannot shade the bookkeeper-server jar inside BKJM 
> jar
> LAYOUT znode created by BookieServer is not readable by the BKJM as it have 
> classes in hidden packages. (same problem vice versa)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to