----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8035/#review13964 -----------------------------------------------------------
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java <https://reviews.apache.org/r/8035/#comment29872> Create another JIRA for this TODO bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java <https://reviews.apache.org/r/8035/#comment29875> There's a problem here. If you only read maxEntriesPerScan in each scan, then when you pass msActiveLedgers to doGC, it may not contain all active ledger ids (if there are more ledgers than maxEntriesPerScan). This will result in any ledger which were not in the scan, but which do exist, being gc'd. bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java <https://reviews.apache.org/r/8035/#comment29873> From ZooKeeper? Surely from metastore bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java <https://reviews.apache.org/r/8035/#comment29874> Again, the zk reference is incorrect. - Ivan Kelly On Nov. 13, 2012, 4:53 a.m., Jiannan Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8035/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2012, 4:53 a.m.) > > > Review request for bookkeeper. > > > Description > ------- > > Implement a MetaStore based ledger manager for bookkeeper client. > > > This addresses bug BOOKKEEPER-205. > https://issues.apache.org/jira/browse/BOOKKEEPER-205 > > > Diffs > ----- > > > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java > e6a3807 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java > 2692fde > > bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java > PRE-CREATION > > bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java > 16c0276 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/metastore/TestMetaStore.java > d528a18 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/BookieLedgerIndexTest.java > ead3494 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java > 2f39536 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerMultiDigestTestCase.java > 9630d46 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java > dd3450c > > Diff: https://reviews.apache.org/r/8035/diff/ > > > Testing > ------- > > > Thanks, > > Jiannan Wang > >
