[ https://issues.apache.org/jira/browse/BOOKKEEPER-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537143#comment-13537143 ]
Hadoop QA commented on BOOKKEEPER-447: -------------------------------------- Testing JIRA BOOKKEEPER-447 Patch [0001-BOOKKEEPER-447-EntryLog-throws-NoSuchEntry-on-short-.patch|https://issues.apache.org/jira/secure/attachment/12561910/0001-BOOKKEEPER-447-EntryLog-throws-NoSuchEntry-on-short-.patch] downloaded at Thu Dec 20 16:23:33 UTC 2012 ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 120 . {color:green}+1{color} the patch does adds/modifies 1 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 FINDBUGS{color} . {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings {color:green}+1 TESTS{color} . Tests run: 506 {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:green}*+1 Overall result, good!, no -1s*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/162/ > Bookie can fail to recover if index pages flushed before ledger flush > acknowledged > ---------------------------------------------------------------------------------- > > Key: BOOKKEEPER-447 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-447 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-server > Affects Versions: 4.2.0 > Reporter: Yixue (Andrew) Zhu > Assignee: Ivan Kelly > Fix For: 4.2.0, 4.1.1 > > Attachments: > 0001-BOOKKEEPER-447-EntryLog-throws-NoSuchEntry-on-short-.patch, > 0001-BOOKKEEPER-447-EntryLog-throws-NoSuchEntry-on-short-.patch, > 0001-BOOKKEEPER-447-EntryLog-throws-NoSuchEntry-on-short-.patch, > 0001-BOOKKEEPER-447-LedgerCacheImpl-waits-on-lock-object-.patch, > 0001-BOOKKEEPER-447-LedgerCacheImpl-waits-on-lock-object-.patch, > 0001-BOOKKEEPER-447-LedgerCacheImpl-waits-on-semaphore-no.patch, > 0001-BOOKKEEPER-447-Throw-NoSuchEntry-if-entry-is-not-fou.patch, > BOOKKEEPER-447_bitset.diff, BOOKKEEPER-447.diff, > BOOKKEEPER-447_force_flush_entry_logger.patch, perf.png > > > Bookie index page steal (LedgerCacheImpl::grabCleanPage) can cause index file > to reflect unacknowledged entries (due to flushLedger). Suppose ledger and > entry fail to flush due to Bookkeeper server crash, it will cause ledger > recovery not able to use the bookie afterward, due to > InterleavedStorageLedger::getEntry throws IOException. > If the ackSet bookies all experience this problem (DC environment), the > ledger will not be able to recover. > The problem here essentially a violation of WAL. One reasonable fix is to > track ledger flush progress (either per-ledger entry, or per-topic message). > Do not flush index pages which tracks entries whose ledger (log) has not been > flushed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira