[
https://issues.apache.org/jira/browse/BOOKKEEPER-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541055#comment-13541055
]
Flavio Junqueira commented on BOOKKEEPER-516:
---------------------------------------------
Just to be clear, you're proposing to close this jura by committing Ivan's
first patch, right, Sijie?
I have one small comment about the patch. In the case
"maybeSendSpeculativeRead(someValue).get()" is null,
"maybeSendSpeculativeRead(someValue).get().equals(ensemble.get(someValue))"
will throw an NPE, no? Is it ok?
> TestSpeculativeRead failed in Jenkins
> -------------------------------------
>
> Key: BOOKKEEPER-516
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-516
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Reporter: Flavio Junqueira
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.2.0
>
> Attachments:
> 0001-BOOKKEEPER-516-TestSpeculativeRead-failed-in-Jenkins.patch,
> BOOKKEEPER-516.diff
>
>
> Here is the jenkins link:
> https://builds.apache.org/job/bookkeeper-trunk/org.apache.bookkeeper$bookkeeper-server/864/testReport/
> and concretely the relevant part of the stack traces:
> {noformat}
> junit.framework.AssertionFailedError: null
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.assertTrue(Assert.java:20)
> at junit.framework.Assert.assertTrue(Assert.java:27)
> at
> org.apache.bookkeeper.client.TestSpeculativeRead$LatchCallback.expectSuccess(TestSpeculativeRead.java:100)
> at
> org.apache.bookkeeper.client.TestSpeculativeRead.testSpeculativeReadFirstReadCompleteIsOk(TestSpeculativeRead.java:268)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
