[
https://issues.apache.org/jira/browse/BOOKKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542224#comment-13542224
]
Ivan Kelly commented on BOOKKEEPER-472:
---------------------------------------
Regarding in-process/out-of-process, im ok with the former for now. If it turns
out to be problematic, we can change it.
I have a few comments about the patch. Apart from these it's ready to go
# rename the config option to "autoRecoveryDaemonEnabled". Theres a typo in it
now.
# ServerConfiguration#setAutoRecoveryDaemonEnabled() should take a boolean
parameter.
# BookieServer#autoRecoveryMain is never set to null initially.
# Typo in name of AutoRecoveryMain#isAutoRecoveryRunning
> Provide an option to start Autorecovery along with Bookie Servers
> -----------------------------------------------------------------
>
> Key: BOOKKEEPER-472
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-472
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-472.patch
>
>
> We can also have an option to start the Autorecovery along with Bookie
> servers.
> If some users are not having too much load on the servers, they can even
> start them along the Bookie servers. If they feel, Auditor would disturb
> Bookie performance, they can anyway start as separate process.
> In another case, deployment overhead will reduce a bit as Monitoring process
> need not monitor one more process in their lifcycles etc.
> Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
