[ https://issues.apache.org/jira/browse/BOOKKEEPER-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543225#comment-13543225 ]
Flavio Junqueira commented on BOOKKEEPER-513: --------------------------------------------- bq. a 4.1 will only recognise the values it had in the OperationType enum, so no CLOSESUBSCRIPTION. If CLOSESUBSCRIPTION is the last value of the enum, then a 4.1 server won't recognise. We just need to make sure that the 4.1 branch will do the right thing if a server receives an unknown operation type. bq. A way to resolve this would be to detect the server protocol version, and only send close if it's greater than what we have in 4.2. However, this doesn't work either. ProtocolVersion is also an enum, so adding another value there will break protobuf compatibility with 4.1. I was wondering if it would be ok to have a patch for 4.1 to make sure that we don't break compatibility. It is not exactly as bug fix for 4.1, but it is not supposed to be a major change either, no? > TestMessageFilter fails periodically > ------------------------------------ > > Key: BOOKKEEPER-513 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-513 > Project: Bookkeeper > Issue Type: Bug > Reporter: Ivan Kelly > Fix For: 4.2.0 > > Attachments: > 0001-BOOKKEEPER-513-TestMessageFilter-fails-periodically.patch, > TEST-org.apache.hedwig.server.filter.TestMessageFilter.xml, > TEST-org.apache.hedwig.server.persistence.MessageBoundedPersistenceTest.xml > > > Running org.apache.hedwig.server.filter.TestMessageFilter > Tests run: 9, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 6.779 sec <<< > FAILURE! > Results : > Tests in error: > > testChangeSubscriptionPreferences(org.apache.hedwig.server.filter.TestMessageFilter): > Server responded with a status code of: TOPIC_BUSY > > testChangeSubscriptionPreferencesForClientFilter(org.apache.hedwig.server.filter.TestMessageFilter): > Server responded with a status code of: TOPIC_BUSY -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira