[
https://issues.apache.org/jira/browse/BOOKKEEPER-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547816#comment-13547816
]
Ivan Kelly commented on BOOKKEEPER-538:
---------------------------------------
awaitTermination doesn't force anything. It waits until any operations on the
scheduler finish. #shutdownNow will force the operations to finish, but this
patch doesn't use that. I'm making a few changes now, and will attach a new
patch shortly.
> Race condition in BookKeeper#close
> ----------------------------------
>
> Key: BOOKKEEPER-538
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-538
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments:
> 0001-BOOKKEEPER-538-Race-condition-in-BookKeeper-close.patch
>
>
> I've seen this with BookieAutoRecoveryTest. Basically, we interrupt and join
> the replicationworker thread, and then close the BookKeeper instance. This
> can have caused a bookkeeper operation that never finished. The executor runs
> it after #close has closed the BookieClient. The operation opens a connection
> and therefore we get a hang on releaseExternalResources().
> Solution is pretty simple. We should shutdown all executors before closing
> the bookieClient. I'll attach a patch which does this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
