[ https://issues.apache.org/jira/browse/BOOKKEEPER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607695#comment-13607695 ]
Hadoop QA commented on BOOKKEEPER-582: -------------------------------------- Testing JIRA BOOKKEEPER-582 Patch [0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch|https://issues.apache.org/jira/secure/attachment/12574552/0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch] downloaded at Wed Mar 20 14:40:43 UTC 2013 ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:red}-1{color} the patch contains 247 line(s) with trailing spaces . {color:red}-1{color} the patch contains 30 line(s) longer than 120 characters . {color:green}+1{color} the patch does adds/modifies 4 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:red}-1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:red}-1{color} patch does not compile . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 FINDBUGS{color} . {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings {color:red}-1 TESTS{color} - patch does not compile, cannot run testcases {color:red}-1 DISTRO{color} . {color:red}-1{color} distro tarball fails with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/293/ > Make bookie and client use protobuf for requests (non-wire part) > ---------------------------------------------------------------- > > Key: BOOKKEEPER-582 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-582 > Project: Bookkeeper > Issue Type: Sub-task > Reporter: Ivan Kelly > Assignee: Ivan Kelly > Fix For: 4.3.0 > > Attachments: > 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, > 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, > 0003-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch > > > Make the client and the bookie use protobufs internally. This is the first > step to using protobufs on the wire, but for the moment, BookieRequestHandler > decodes the old wire protocol into the protobuf messages. Once this is in, > enabling on the wire will be very simple, and the old manual serialization > can be made "legacy" (still supported, but deprecated). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira